Last modified: 2007-05-07 00:46:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11244, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9244 - edits to non-existent section are silently discarded.
edits to non-existent section are silently discarded.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 8902 (view as bug list)
Depends on:
Blocks: 4899
  Show dependency treegraph
 
Reported: 2007-03-09 23:09 UTC by Steve Sanbeg
Modified: 2007-05-07 00:46 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Steve Sanbeg 2007-03-09 23:09:07 UTC
This can be shown by creating a template with a few sections, then transcluding
it into a new page (i.e. a new user's talk page)

If these were wiki sections, then if the newbie clicked the edit links on their
page, they would edit the template, which would not be desired.  If these are
HTML sections, the links would instead point to the transcluding page;
presumably a bug, but seems like what they'd expect in this case.

But if it's a new page, those sections won't exist, so any edits to them will
just be silently discarded.

Ideally, either these should be appended to the end, or the edit link should
give an error.
Comment 1 Steve Sanbeg 2007-03-14 18:21:54 UTC
I've committed a fix in r20459.  That adds a new error message, currently only
in English.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-15 01:25:40 UTC
(In reply to comment #0)
> If these were wiki sections, then if the newbie clicked the edit links on their
> page, they would edit the template, which would not be desired.  If these are
> HTML sections, the links would instead point to the transcluding page;
> presumably a bug, but seems like what they'd expect in this case.

This should be fixed too (new bug report?).  It makes no sense for the edit links to point to a 
nonexistent section, generating an error message is just putting a Band-Aid on it.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-15 01:27:12 UTC
Never mind, that's bug 4034.
Comment 4 Steve Sanbeg 2007-03-15 16:58:20 UTC
(In reply to comment #3)
> Never mind, that's bug 4034.

Also 9291.  Generally, silently discarding edits is bad.  If it could only be
triggered from contrived URLs, it may not be worth fixing; but problems with
section edit links pointing to the wrong place recurs too often to be the last
line of defense.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-07 00:46:44 UTC
*** Bug 8902 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links