Last modified: 2010-05-15 15:48:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11235, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9235 - UseTidy breaks code generated by Gallery tag
UseTidy breaks code generated by Gallery tag
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.9.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-09 02:57 UTC by Dallas Warren
Modified: 2010-05-15 15:48 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dallas Warren 2007-03-09 02:57:09 UTC
Due to current rendering issues with tables / if statements etc, needed to
enable $UseTidy.

When this is done, the image table generated by the <gallery></gallery> tag gets
messed up.  It is also a problem with the RandomImages extension (suspect they
use the same code somewhere).

What appears to be happening is that some of the opening and closing tags of the
code is generated as & gt; or & lt;. Which then means that things fail, get
funny bits of code appearing on the page etc. The gallery generating code was
working fine before enabling $wgUseTidy.

Because of the tags being messed up, the following is visible under the
thumbnails generated by the gallery tag (as well as with RandomImage):
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

More details of it are documented here -
http://www.mediawiki.org/wiki/Manual_talk:%24wgUseTidy

Problem since noticed it with 1.8.2.

What it looks like when viewed using Firefox: http://ozreef.org/stuff/Screenshot.png

What it looks like when viewed using IE:
http://www.project-a.com.au/images/Nathan/Feb07/screengrab1.jpg
Comment 1 Brion Vibber 2007-03-09 17:27:49 UTC
It looks like you're missing the tidy configuration file.
The default one we provide is in the extensions module, in extensions/tidy.
Comment 2 Dallas Warren 2007-03-13 03:21:13 UTC
Sorry if this is a stupid question, but I have been searching high and low
(Google, MediaWiki, MetaWiki) for a default tidy configuration file in the
extensions module, and have found nothing.  Not even really a mention of one.

Where is this meant to be obtained from?

FYI, Tidy is working, and it is using the configuration file that is the default
for Tidy on the server itself.  The configuration file exists, it is in the
default location that tidy looks for the configuration file etc.

Ahh, think I have finally found it:
http://meta.wikimedia.org/wiki/Data_dumps#Common_Problems_and_Solutions under
the heading "After I run importDump.php or mwdumper, the articles are messed up.
Templates are skewed and do not display properly. what can I do?"

Seeing if that is appropriate and fixes the issue.
Comment 3 Dallas Warren 2007-03-13 03:32:31 UTC
That appears to be it!

Damit, something so simple.  I have updated the various locations where i have
made comments about this, that a tidy.conf needs to be included.  Will update
some details in the manual about tidy to note that as well.
Comment 4 Brion Vibber 2007-03-13 15:42:10 UTC
Note that I've moved the default location for the tidy.conf into
includes/tidy.conf, so as of MediaWiki 1.10 it won't be necessary to fetch
extensions files separately for this.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links