Last modified: 2009-12-15 10:23:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9230 - Hook at end of sidebar in Monobook
Hook at end of sidebar in Monobook
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-08 19:20 UTC by Robert Leverington
Modified: 2009-12-15 10:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for this issue (1.01 KB, patch)
2007-03-08 19:20 UTC, Robert Leverington
Details
ok this should work, but it still doesn't load in to BugZilla how I want ;( (985 bytes, patch)
2007-03-08 20:36 UTC, Robert Leverington
Details

Description Robert Leverington 2007-03-08 19:20:12 UTC
It would be nice to have a hook at the end of the sidebar so extensions can add
adverts for example. This would only be in Monobook as other skins use a
different layout, they can be added for other skins in a different bug report.
Comment 1 Robert Leverington 2007-03-08 19:20:48 UTC
Created attachment 3323 [details]
Patch for this issue
Comment 2 Robert Leverington 2007-03-08 20:36:39 UTC
Created attachment 3324 [details]
ok this should work, but it still doesn't load in to BugZilla how I want ;(
Comment 3 Rob Church 2007-03-08 22:02:10 UTC
Comment on attachment 3324 [details]
ok this should work, but it still doesn't load in to BugZilla how I want ;(


Documentation is incorrect.
Comment 4 Robert Leverington 2007-03-09 20:05:43 UTC
Comment on attachment 3324 [details]
ok this should work, but it still doesn't load in to BugZilla how I want ;(


>Index: /docs/hooks.txt
>===================================================================
>--- /docs/hooks.txt	(revision 20260)
>+++ /docs/hooks.txt	(working copy)
>@@ -416,6 +416,9 @@
> $mathRenderer: instance of MathRenderer
> $errmsg: error message, in HTML (string). Nonempty indicates failure
>  of rendering the formula
>+ 
>+'MonobookSkinSidebarEnd': at end of sidebar in Monobook page
>+$this is an instance of the monobook skin
> 
> 'OutputPageBeforeHTML': a page has been processed by the parser and
> the resulting HTML is about to be displayed.  
>/skins/MonoBook.php
>===================================================================
>--- /skins/MonoBook.php	(revision 20260)
>+++ /skins/MonoBook.php	(working copy)
>@@ -242,6 +242,7 @@
> 		</div>
> 	</div>
> <?php	} ?>
>+	wfRunHooks( 'MonoBookSkinSidebarEnd', array( &$this ) );
> 		</div><!-- end of the left (by default at least) column -->
> 			<div class="visualClear"></div>
> 			<div id="footer">
Comment 5 Robert Leverington 2007-03-09 20:21:33 UTC
Comment on attachment 3324 [details]
ok this should work, but it still doesn't load in to BugZilla how I want ;(


Index: /docs/hooks.txt
===================================================================
--- /docs/hooks.txt	(revision 20260)
+++ /docs/hooks.txt	(working copy)
@@ -416,6 +416,9 @@
 $mathRenderer: instance of MathRenderer
 $errmsg: error message, in HTML (string). Nonempty indicates failure
  of rendering the formula
+ 
+'MonobookSkinSidebarEnd': at end of sidebar in Monobook page
+$this: Code to be executed

 'OutputPageBeforeHTML': a page has been processed by the parser and
 the resulting HTML is about to be displayed.  
Index: C:/Program Files/xampp/htdocs/mw/skins/MonoBook.php
===================================================================
--- /skins/MonoBook.php (revision 20260)
+++ /skins/MonoBook.php (working copy)
@@ -242,6 +242,7 @@
		</div>
	</div>
 <?php	} ?>
+	wfRunHooks( 'MonoBookSkinSidebarEnd', array( &$this ) );
		</div><!-- end of the left (by default at least) column -->
			<div class="visualClear"></div>
			<div id="footer">
Comment 6 Alexandre Emsenhuber [IAlex] 2009-10-17 08:38:23 UTC
Can the new SkinBuildSidebar hook (http://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar) be usefult for this?
Comment 7 Chad H. 2009-12-15 10:23:16 UTC
(In reply to comment #6)
> Can the new SkinBuildSidebar hook
> (http://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar) be usefult for
> this?
> 

Yes. The hook allows you to add new items to the sidebar or inject arbitrary HTML. Marking this FIXED.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links