Last modified: 2007-03-08 01:41:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11217, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 9217 - Skin.php is missing a wfProfileOut call
Skin.php is missing a wfProfileOut call
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-reviewed
Depends on:
Blocks: code_quality
  Show dependency treegraph
Reported: 2007-03-07 18:36 UTC by MrPete
Modified: 2007-03-08 01:41 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description MrPete 2007-03-07 18:36:29 UTC
Should be obvious -- an unbalanced set of wfProfileIn but no matching
wfProfileOut :)

Index: Skin.php
--- Skin.php	(revision 20208)
+++ Skin.php	(working copy)
@@ -269,6 +269,7 @@
 		$out->out( $out->reportTime() );
 		$out->out( "\n</body></html>" );
+		wfProfileOut( 'Skin::outputPage' );
 	static function makeVariablesScript( $data ) {
Comment 1 Rob Church 2007-03-07 20:56:37 UTC
Note that wfProfileIn( __METHOD__ ) and wfProfileOut( __METHOD__ ) are preferred
now, except where the profiling needs to be broken down into independent levels
per function, e.g. "Setup" is profiled in various different segments, as are a
number of the larger functions.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-08 01:41:09 UTC
Fixed in r20217.

Note You need to log in before you can comment on or make changes to this bug.