Last modified: 2014-09-23 22:39:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9120 - Special:Nuke does not list imported pages
Special:Nuke does not list imported pages
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
Nuke (Other open bugs)
unspecified
PC All
: Low normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
: 25607 30141 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-27 21:30 UTC by Dan Barrett
Modified: 2014-09-23 22:39 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch as described in comment 5 (516 bytes, patch)
2010-01-26 21:15 UTC, Frank Ralf
Details

Description Dan Barrett 2007-02-27 21:30:36 UTC
Special:Nuke does not work for pages that were imported with Special:Import.
These pages simply don't get listed (in the checkbox list) when you search for
the username under which they were imported.

Here is a sample import that does not show up when you search for the username
under which it was imported (in this case, WikiSysop, which happens to be uid = 1):

<mediawiki xmlns="http://www.mediawiki.org/xml/export-0.3/"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.mediawiki.org/xml/export-0.3/
http://www.mediawiki.org/xml/export-0.3.xsd" version="0.3" xml:lang="en">

 <page>
    <title>My new topic</title>
    <revision>
      <contributor>
        <username>WikiSysop</username>
        <id>1</id>
      </contributor>
      <text xml:space="preserve">
{{stub}}

[[Category:MyCat]]
      </text>
    </revision>
  </page>
</mediawiki>
Comment 1 Dan Barrett 2007-02-27 21:31:13 UTC
This is in MediaWiki 1.9.2.
Comment 2 Dan Barrett 2007-02-27 21:50:32 UTC
I am guessing that Special:Import does not update the recentchanges table, so
Nuke doesn't know about imports.
Comment 3 Cameron Moody 2008-07-23 03:09:01 UTC
I have the same situation but running with MediaWiki 1.12. I have also checked in the Special:Recentchanges page and the imported pages do appear there. I also ran select * from recentchanges; and there are log entries in the table for the imports.

Would definately appreciate some ideas on getting this working. In case they are interlinked - I also experience the same behavior as bugzilla ID 14725 (same article title listed numerous times with different edit counts).
Comment 4 Mike.lifeguard 2008-10-09 04:25:12 UTC
(In reply to comment #2)
> I am guessing that Special:Import does not update the recentchanges table, so
> Nuke doesn't know about imports.
> 

To do so, do we need a hook for import? That'd be bug 11539 or bug 11537.
Comment 5 Frank Ralf 2010-01-26 19:39:26 UTC
Nuke actually queries for imported pages, but the line

 '(rc_new = 1) OR (rc_log_type = "upload" AND rc_log_action = "upload")'

in file SpecialNuke_body.php must be changed to

 '(rc_new = 1) OR (rc_log_type = "import" AND rc_log_action = "upload")'

as the log type is called "import" (http://www.mediawiki.org/wiki/Recentchanges_table#rc_log_type). That seems to do the trick - at least the pages show up for Nuke.
Comment 6 Frank Ralf 2010-01-26 21:15:37 UTC
Created attachment 7020 [details]
Patch as described in comment 5
Comment 7 Sam Reed (reedy) 2010-07-27 12:00:52 UTC
r70005

Thanks for the Patch :)
Comment 8 p858snake 2010-11-04 07:19:06 UTC
*** Bug 25607 has been marked as a duplicate of this bug. ***
Comment 9 Bawolff (Brian Wolff) 2011-02-26 00:41:26 UTC
reverted in r82823. This doesn't distinguish between imports to already existing pages, and newly created pages, and only newly created pages. Also breaks listing file uploads.
Comment 10 untill 2011-04-22 18:49:59 UTC
Still a problem in 1.16.2.
Comment 11 Krinkle 2011-04-23 13:16:42 UTC
I'm not sure we can or should fix this bug.

What if an import took place (which imported pages created on another wiki by a certain username, a username that does not exist on the the local wiki), then a vandal creates an account with that name and creates a bunch of spam pages.

An admin wants to nuke the spam pages, and only pages created by that user should be affected, not the imported pages.

If it were some other function I wouldn't find it as much of an issue, but since the Nuke extension is especially created for vandalism related cases, I think it's a blocker.

Proposing WONTFIX.
Comment 12 Krinkle 2011-04-23 13:17:29 UTC
Hm... a possible work around would be to have the Nuke-extension get pages from recentchanges by user id, instead of username (and get user id from user table).
Comment 13 Dan Barrett 2011-04-23 13:37:42 UTC
Krinkle: How about making an option (checkbox) to "Also delete imported changes"?
Comment 14 Bawolff (Brian Wolff) 2011-04-23 15:58:07 UTC
I think this bug only really makes sense if you want to delete all the pages imported by the user importing them (as opposed to by the user listed as the author)
Comment 15 p858snake 2011-04-30 00:09:55 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 16 Sumana Harihareswara 2011-11-14 16:15:23 UTC
Marking patch reviewed.  Frank, do you have time to revise it, and interest in doing so?  Thanks.
Comment 17 db [inactive,noenotif] 2012-09-08 18:58:45 UTC
*** Bug 30141 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links