Last modified: 2007-04-25 16:53:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 9102 - Cookie message optional + Es internationalization
Cookie message optional + Es internationalization
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ConfirmEdit (CAPTCHA extension) (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-25 19:08 UTC by Platonides
Modified: 2007-04-25 16:53 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
captchahelp-cookies-needed + Es internationalization (7.14 KB, patch)
2007-02-25 19:08 UTC, Platonides
Details
captchahelp-cookies-needed + Es internationalization v2 (7.67 KB, patch)
2007-03-06 08:47 UTC, Platonides
Details

Description Platonides 2007-02-25 19:08:18 UTC
Made reference "You will need to have cookies enabled in your browser for this
to work." optional.
This is moved to captchahelp-cookies-needed, which replaces $1 on
captchahelp-text if wgCaptchaStorageClass uses cookies (exposed via
cookies_needed() ).

Added Es internationalization. En and Fr updated to use
captchahelp-cookies-needed. Languages not using it use old method (no changes).
Comment 1 Platonides 2007-02-25 19:08:58 UTC
Created attachment 3271 [details]
captchahelp-cookies-needed + Es internationalization
Comment 2 Brion Vibber 2007-03-06 05:14:39 UTC
A few notes:

* Avoid putting whitespace (spaces or newlines) at the end of messages;
trailing whitespace is removed when pages are saved, so a message ending in \n
couldn't be saved as an in-wiki customization properly.

* This line is very odd:
+		$wgOut->addWikiText( str_replace('$1', $this->storage->cookies_needed() ?
wfMsg( 'captchahelp-cookies-needed' ) : '', wfMsg( 'captchahelp-text' ) ) );

wfMsg() takes parameters; use them!

* Stick with naming conventions; cookieNeeded instead of cookie_needed

Comment 3 Platonides 2007-03-06 08:47:11 UTC
Created attachment 3295 [details]
captchahelp-cookies-needed + Es internationalization v2

*Line feeds moved to the beginning (they are added so
captchahelp-cookies-needed appears on its own line, while avoiding extra lines
if it doesn't appear).

*Didn't know. Done.

*Changed to camelCase.
Comment 4 Raimond Spekking 2007-04-25 16:53:57 UTC
Applied with r21574.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links