Last modified: 2007-08-22 08:08:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T11026, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 9026 - Auto numbering of headers not working correctly on Special:Statistics page.


Summary:	Auto numbering of headers not working correctly on Special:Statistics page.

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://ksh.wikipedia.org/wiki/Spezial...
Whiteboard:
Keywords:	easy, patch, patch-need-review

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-02-18 21:38 UTC by Purodha Blissenbach
Modified:	2007-08-22 08:08 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch (2.25 KB, patch) 2007-06-15 14:50 UTC, Thomas "Tango" Dalton	Details
patch2 (2.31 KB, patch) 2007-06-15 15:31 UTC, Thomas "Tango" Dalton	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Purodha Blissenbach 2007-02-18 21:38:49 UTC

Our
[[MediaWiki:Statistics-footer]] defines another headline, which is 
not numbered in [[Spezial:Statistics]] even if auto header 
numbering is enabled in the [[Special:Preferences]] for the user. 
The other two headlines do have numbers.

Comment 1 Rob Church 2007-06-11 06:53:48 UTC

Not all headlines on the page are parsed at the same time; this would be more evident to the user if the page counters were enabled, since the suppressed "page views" section would be shown.

The simple solution is to prepare the full text for the page and parse it in one go.

Comment 2 Thomas "Tango" Dalton 2007-06-15 14:50:46 UTC

Created attachment 3780 [details]
patch

I think this does what you suggest. Two possible things wrong with it:

1) The makeTitleSafe bit probably isn't needed now it's wikitext not HTML, but I'm not sure, so I left it there
2) I've removed the direction mark, but I'm not if I should have or not

Please let me know if they need changing. Thanks!

Comment 3 Thomas "Tango" Dalton 2007-06-15 15:31:03 UTC

Created attachment 3782 [details]
patch2

New patch with my two questions fixed (thanks Tim!).

Comment 4 Rob Church 2007-08-22 08:08:49 UTC

Fixed in r25039, r25040.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links