Last modified: 2014-09-23 23:41:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8954 - Visual coloured math diffs
Visual coloured math diffs
Status: NEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.10.x
All All
: Low enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://bighead.poli.usp.br/mwiki-svn/...
: design, patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-02-12 05:09 UTC by Felipe Corrêa da Silva Sanches
Modified: 2014-09-23 23:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Coloured math diffs patch (3.03 KB, patch)
2007-02-12 05:11 UTC, Felipe Corrêa da Silva Sanches
Details

Description Felipe Corrêa da Silva Sanches 2007-02-12 05:09:57 UTC
This patch renders math equations in the diff pages colouring it the same way
the diffengine colours text diffs.

See the example at the above URL.
Comment 1 Felipe Corrêa da Silva Sanches 2007-02-12 05:11:34 UTC
Created attachment 3210 [details]
Coloured math diffs patch
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-12 16:00:23 UTC
This appears to also make the math background transparent.  That has been
rejected before, because it's possible that the user will be using a very dark
background color, making the text (which is always black) hard or impossible to
read.  Try to keep unrelated changes out of patches, so that they're easier to
review.

Other than that, it looks to be quite a nice change.  I'm slightly concerned
with usability, though, because presumably most non-image clients won't render
the \color bit as distinctly as they'll probably render the <ins> or <del>. 
Perhaps set the alt text on the images to the empty string, and put the text of
the math tag immediately below it.  I.e., instead of

<img src="..." alt="x{\color{red}^2}" />

have

<img src="..." alt="" />
<math>x<ins class="diffchange">^2</ins></math>.  Of course, that means that
visual clients will also see the superfluous diff of the actual math text, but
perhaps that's a feature: it will quickly show them what bits they need to
change in the wikitext to partially reverse the change, say.
Comment 3 Felipe Corrêa da Silva Sanches 2007-02-12 22:05:29 UTC
I thought that it would look better. Maybe we could solve it by setting the math
foreground color to match the CSS settings. But I have no idea of how to fetch
this info using php code.

We can also get rid of this problem if we let the user select this feature as a
user preference.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-12 22:19:53 UTC
Please confine any background-transparency remarks to bug 6954.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-14 03:06:30 UTC
As Rob reminds me at bug 8981 comment 1, as written this will have no effect on
WMF sites, because we use wikidiff2 for diffs.

http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/wikidiff2/
Comment 6 p858snake 2011-04-30 00:10:17 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 7 Sumana Harihareswara 2011-11-10 02:51:08 UTC
I'm adding the "reviewed" keyword here because Aryeh has reviewed the patch.  Thanks for the patch, Felipe; do you have interest and time to rework it?
Comment 8 Andre Klapper 2014-07-07 12:08:04 UTC
CC'ing the Math maintainers in case they can provide input how complicated / feasible this could be.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links