Last modified: 2010-05-15 15:33:32 UTC
BUG MIGRATED FROM SOURCEFORGE http://sourceforge.net/tracker/index.php?func=detail&aid=967483&group_id=34373&atid=411192 Originally submitted by Nobody/Anonymous - nobody 2004-06-06 10:31 When using {{subst:}} with a parameterized template, the parameters are not substituted. The template is simply brought in as-is. For an example, see http://meta.wikipedia.org/wiki/MediaWiki_1.3_comments_and_bug_reports#Subst_and_parameterized_templates -- [[en:User:Cyrius]]
*** Bug 104 has been marked as a duplicate of this bug. ***
*** Bug 155 has been marked as a duplicate of this bug. ***
Created attachment 22 [details] Proposed patch for parameterized template substitution I've developed a patch to enable substituted templates to make use of parameters at the time of substitution. I've done some quick tests of the patched code on a local test installation of MediaWiki from the latest CVS sources and things seem to work fine, but I don't know enough to do adequate regression testing. I have limited the effect of my changes to template substitution performed when mOutputType == OT_WIKI, so if there's any reason to include other output types (such as OT_MSG) then the code will have to be adjusted accordingly. This is my first-ever contribution to MediaWiki code and I'm not a PHP guru, so please scrutinize my code carefully because there's a good chance that I haven't a clue what I'm doing. :)
Alan, thanks for looking at the code and submitting a patch. I am also inexperienced in MediaWiki development, so I'm not an expert on this area either. But I think you have the right idea for how to implement this change. I noticed a problem, however; if I understand your patch correctly, it causes variables to be substituted during the preSaveTransform phase, whereas before your patch only {{subst:}} type templates were substituted. For example, if I create a page using the current CVS code with the magic variable {{CURRENTTIME}}, it is saved to the database without substitution, so every time I view the page it displays the current time. But with your patch applied, if I create the same page, the parser substitutes the current time when I save the page. Thus the page will always display the fixed time at which I saved the page, rather than dynamically updating as intended. I don't think it will be difficult to address this issue. Thanks again for the patch.
Fixed in HEAD (Parser.php revision 1.294). Thanks to Alan for the patch, which I modified to address the problem I mentioned and to work with other recent Parser changes.
Resolving as fixed with 1.4 release imminent.
