Last modified: 2013-12-08 21:00:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8844 - Wrap Recent changes, Recent changes linked & Watchlist in <div class="mw-changeslist" />
Wrap Recent changes, Recent changes linked & Watchlist in <div class="mw-chan...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.11.x
All All
: Low enhancement with 1 vote (vote)
: 1.23.0 release
Assigned To: Bartosz Dziewoński
: easy
Depends on:
Blocks: 51942
  Show dependency treegraph
 
Reported: 2007-02-01 05:28 UTC by Danny B.
Modified: 2013-12-08 21:00 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Danny B. 2007-02-01 05:28:10 UTC
Please wrap recent chages list in <div id="recentchanges">

<div id="recentchanges"> <!-- added -->
<h4>date</h4>
<div>
change<br />
change<br />
change<br />
</div>
<h4>date</h4>
<div>
change<br />
change<br />
change<br />
</div>
</div> <!-- added -->

Reason: easier CSS and DOM access to items, especially on projects with low
number of changes

setting of styles eg. for particular <a> elements has to be done really ugly way
now:
div.rcoptions + h4 + div a
div.rcoptions + h4 + div + h4 + div a
div.rcoptions + h4 + div + h4 + div + h4 + div a
etc. depending on how many days can appear on rc page

#recentchanges div a
would be much easier.

Thanks
Comment 1 Rob Church 2007-02-01 08:21:39 UTC
*Just* for recent changes, or on all changes pages?
Comment 2 Danny B. 2007-02-01 15:23:02 UTC
(In reply to comment #1)
> *Just* for recent changes, or on all changes pages?

Very good idea - recent changes linked and watchlist would need it as well.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-01 17:43:36 UTC
Probably it should be something like id="recentchanges-lists", id="recentchangeslinked-lists", 
and so on, with class="changes-lists" or something.  And maybe add a class="changes-list" to the 
ul's while we're at it.

Note that it's already possible to do appropriate selection, though:

body.page-Special_Recentchanges ul.special a { ... }
Comment 4 Danny B. 2007-02-01 20:33:28 UTC
(In reply to comment #3)
> Probably it should be something like id="recentchanges-lists",
id="recentchangeslinked-lists", 
> and so on, with class="changes-lists" or something.  And maybe add a
class="changes-list" to the 
> ul's while we're at it.
> 
> Note that it's already possible to do appropriate selection, though:
> 
> body.page-Special_Recentchanges ul.special a { ... }

I don't know if you plan to do these lists like <ul> (which would be great), but
they are not now, thus the example above does not work.
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-01 20:40:15 UTC
At enwiki's [[Special:Recentchanges]], I get:

<h4>1 February 2007</h4>
<ul class="special"><li>(<a href="/w/
index.php?title=Young_Buck&amp;curid=741134&amp;diff=104919445&amp;oldid=104869982" title="Young 
Buck"  tabindex="1">diff</a>) . . .

Are you using an old version?
Comment 6 Brion Vibber 2007-02-02 19:40:43 UTC
Don't use an id, we can't guarantee it unique; there may be multiple lists shown
in a single document.
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-02-02 19:45:48 UTC
Oh, right, you can transclude RC.
Comment 8 Danny B. 2007-02-14 16:43:28 UTC
(In reply to comment #5)
> At enwiki's [[Special:Recentchanges]], I get:
> 
> <h4>1 February 2007</h4>
> <ul class="special"><li>(<a href="/w/
>
index.php?title=Young_Buck&amp;curid=741134&amp;diff=104919445&amp;oldid=104869982"
title="Young 
> Buck"  tabindex="1">diff</a>) . . .
> 
> Are you using an old version?

Enhanced recent changes are not rendered as <ul>, that's basically the deal ;-)
Comment 9 Siebrand Mazeland 2009-02-02 11:50:13 UTC
Changed component to "Watchlist"
Comment 10 Danny B. 2009-02-02 16:03:35 UTC
Changed component back to "Page rendering" - this is not only watchlist issue as summary clearly says.
Comment 11 Bartosz Dziewoński 2013-07-24 10:06:08 UTC
Given the solution mentioned in comment 3 I think this should be WONTFIXed.

(In reply to comment #3)
> Note that it's already possible to do appropriate selection, though:
> 
> body.page-Special_Recentchanges ul.special a { ... }
Comment 12 Bartosz Dziewoński 2013-10-18 18:44:32 UTC
WONTFIX per above.
Comment 13 Danny B. 2013-10-20 01:16:17 UTC
REOPEN per comment #8
Comment 14 Gerrit Notification Bot 2013-11-26 22:14:31 UTC
Change 97853 had a related patch set uploaded by Bartosz Dziewoński:
Wrap changes lists in <div class="mw-changeslist" />

https://gerrit.wikimedia.org/r/97853
Comment 15 Gerrit Notification Bot 2013-12-08 21:00:28 UTC
Change 97853 merged by jenkins-bot:
Wrap changes lists in <div class="mw-changeslist" />

https://gerrit.wikimedia.org/r/97853

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links