Last modified: 2011-02-08 21:56:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8814 - White border around thumbs
White border around thumbs
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: High trivial with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Wikipedi...
:
: 5879 26423 (view as bug list)
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2007-01-28 21:51 UTC by Mormegil
Modified: 2011-02-08 21:56 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of standard exhibiting the bug (52.34 KB, image/png)
2009-06-01 17:05 UTC, Mormegil
Details

Description Mormegil 2007-01-28 21:51:43 UTC
Thumbnailed images outside NS0 have big white border in Standard skin (and possibly others except 
Monobook).

I believe it is because of the "border-color: white;" specification added in r18303, as non-NS0 
pages in Standard do not have white background (they have explicit bgcolor="#ffffec" set by 
Skin::getBodyOptions).
Comment 1 Brion Vibber 2008-03-19 19:55:26 UTC
*** Bug 5879 has been marked as a duplicate of this bug. ***
Comment 2 Siebrand Mazeland 2009-06-01 16:23:09 UTC
I checked this with modern, monobook and standard and they all look the same for the given URL. If indeed fixed, please close.
Comment 3 Mormegil 2009-06-01 17:05:01 UTC
Created attachment 6181 [details]
Screenshot of standard exhibiting the bug

No, it has not been fixed. See the attached screenshot (taken right now on http://en.wikipedia.org/wiki/Wikipedia:Pictures?useskin=standard running 1.15alpha (r48811)).
Comment 4 Bryan Baron 2009-06-22 18:49:49 UTC
Perhaps it could be fixed with a "background-color:inherit" around the thumb.
Comment 5 Derk-Jan Hartman 2010-02-16 14:52:54 UTC
Note that this issue is no longer VISIBLE in the English Wikipedia because of customizing [[MediaWiki:Common.css]] with the following CSS;


/* Remove white border from thumbnails */
div.thumb {
    border: none;
}
div.tright {
    border: none;
    margin: 0.5em 0 0.8em 1.4em;
}
div.tleft {
    border: none;
    margin: 0.5em 1.4em 0.8em 0;
}

The issue still exists in the default skins.
Comment 6 entlinkt 2010-07-23 21:37:01 UTC
See bug 16272 comment 1 for why the borders are there at all. But the desired effect (preventing h2 lines from connecting to floated thumbs) can be achieved in a simpler and more general way by applying overflow:hidden to the h2 elements.

This would work for all floats, not just thumbnails, and also fix bug 1629, but has side-effects:

* overflow:hidden does nothing in IE 6. If that's a problem, the desired effect can be achieved by triggering hasLayout. In IE 7, it works because overflow:hidden has become a hasLayout trigger. It finally works as it should in IE 8.
* Headings would become invisible in IE/Mac, see bug 1629 comment 40 and http://l-c-n.com/IE5tests/overflow/#overflowblock. If that's a problem, it can be he hidden from this ancient browser.
* Bug 1629 comment 38 is about unspecified problems with RTL and Firefox that would have to be looked into.

Besides that, I wonder why every skin needs to contain a copy of this code. Can't this at least be consolidated in shared.css and commonPrint.css? At the German Wikipedia, we have the same workaround as in comment 5 scattered across the local skin-specific CSS files, and there is no consensus to put them in Common.css as long as it's scattered upstream.
Comment 7 entlinkt 2010-07-24 01:24:05 UTC
Note that overflow:hidden can clip content if a heading contains a very long unbreakable word and there is a right float before it. With overflow:visible, content is pushed down the float, but not with overflow:hidden; it's clipped instead.

If it's not worth this risk, I'd suggest to just remove the white borders. They may serve a purpose, but cause rendering inconsistencies (other floats like infoboxes don't have such borders), and many wikis (enwiki, dewiki, commonswiki at least) remove them locally anyway.
Comment 8 Fomafix 2010-12-26 10:21:26 UTC
*** Bug 26423 has been marked as a duplicate of this bug. ***
Comment 9 Krinkle 2010-12-26 12:35:02 UTC
See also bug 26423.

Fixed in r79010 & r79011.

Similar demo on TranslateWiki, which uses the trunk where it'll appear soon
http://translatewiki.net/w/i.php?title=Sandbox&oldid=2584255
(compare with http://www.mediawiki.org/w/index.php?title=Sandbox&oldid=371897 )

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links