Last modified: 2007-05-23 20:03:21 UTC
Though that sometimes you want to get revisions baded on if a specific user made
the revision or not, so I've made a patch to enable that (only in enumeration mode)
Created attachment 3141 [details]
the promised patch
fixed in r22250
Created attachment 3668 [details]
As someone had changed something in the patch before applying, rvuser at the moment doesnt work. Don't know why that edit was made. fix here.
Applied fix in r22368.
My mistake -- I introduced a new parameter type "user", and updated your diff to use it. My mistake was that I kept $this->addWhere($value) instead of using $this->addWhereFld($field, $value), even though i passed two parameters. PHP has no problem with taking more parameters than the function's declaration, hence I never noticed the difference.
I would prefer to use addWhereFld because it automatically appends the quotes and escaping to the value instead of doing it all over the place.
addWhere is for special conditions such as !=, >=, etc.