Last modified: 2007-05-23 20:03:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10772, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 8772 - Parameter to limit results to revisions made by a particular user, when querying revisions for a page
Parameter to limit results to revisions made by a particular user, when query...
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
All All
: High major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-01-25 16:30 UTC by Carl Fürstenberg
Modified: 2007-05-23 20:03 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

the promised patch (3.92 KB, patch)
2007-01-25 16:31 UTC, Carl Fürstenberg
bugfix (605 bytes, patch)
2007-05-23 07:50 UTC, Carl Fürstenberg

Description Carl Fürstenberg 2007-01-25 16:30:59 UTC
Though that sometimes you want to get revisions baded on if a specific user made
the revision or not, so I've made a patch to enable that (only in enumeration mode)
Comment 1 Carl Fürstenberg 2007-01-25 16:31:26 UTC
Created attachment 3141 [details]
the promised patch
Comment 2 Yuri Astrakhan 2007-05-19 04:14:49 UTC
fixed in r22250
Comment 3 Carl Fürstenberg 2007-05-23 07:50:00 UTC
Created attachment 3668 [details]

As someone had changed something in the patch before applying, rvuser at the moment doesnt work. Don't know why that edit was made. fix here.
Comment 4 Brion Vibber 2007-05-23 18:33:12 UTC
Applied fix in r22368.
Comment 5 Yuri Astrakhan 2007-05-23 20:03:21 UTC
My mistake -- I introduced a new parameter type "user", and updated your diff to use it. My mistake was that I kept   $this->addWhere($value) instead of using $this->addWhereFld($field, $value), even though i passed two parameters.  PHP has no problem with taking more parameters than the function's declaration, hence I never noticed the difference.

I would prefer to use addWhereFld because it automatically appends the quotes and escaping to the value instead of doing it all over the place.

addWhere is for special conditions such as !=, >=, etc.

Note You need to log in before you can comment on or make changes to this bug.