Last modified: 2007-01-26 05:47:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10744, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 8744 - Redirect loop if read permission is denied and Main Page is not on whitelist.
Redirect loop if read permission is denied and Main Page is not on whitelist.
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-23 18:11 UTC by Mark Clements (HappyDog)
Modified: 2007-01-26 05:47 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mark Clements (HappyDog) 2007-01-23 18:11:10 UTC
If you set 

  $wgGroupPermissions['*'    ]['read']            = false;

then anonymous users have to login to view any pages not on the whitelist.  If
they attempt to access a page that is not on the whitelist then they are given a
notice that they need to login, and after about 10 seconds the page redirects to
the Main Page.

However, if the Main Page is not on the whitelist, then this results in repeated
reloading of the same page.  The software should detect this condition and only
redirect if the destination is in the whitelist.
Comment 1 Rob Church 2007-01-23 21:47:35 UTC
Are you sure this is still a current problem? I seem to recall adding an
explicit check to that code to prevent an unhelpful "return to" in response to
an almost identical bug report.
Comment 2 Mark Clements (HappyDog) 2007-01-23 21:56:33 UTC
No, actually.

I will check it against HEAD and let you know.
Comment 3 Mark Clements (HappyDog) 2007-01-26 05:47:23 UTC
Found the following at line 871 of OutputPage.php, in function loginToUse() 

 # Don't return to the main page if the user can't read it
 # otherwise we'll end up in a pointless loop
   $mainPage = Title::newMainPage();
   if( $mainPage->userCanRead() )
      $this->returnToMain( true, $mainPage );

So I guess it's already fixed!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links