Last modified: 2010-05-28 14:18:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8689 - Long numeric lines kill the parser
Long numeric lines kill the parser
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.9.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-18 13:50 UTC by Nat Makarevitch
Modified: 2010-05-28 14:18 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Nat Makarevitch 2007-01-18 13:50:21 UTC
Cannot obtain a diff page

To exhibit it:
Go to Wikipedia EN
Try to obtain the diff between:
 # (cur) (last)  2006-03-18T08:06:09 67.49.215.239
 # (cur) (last) 2006-03-18T08:03:39 Rory096

Problem: it simply hangs the serving process (till timeout)

Note: the article ('page') contains a huge line. It seems to me that it somewhat
breaks the parser
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-01-28 17:16:28 UTC
It loads fine for me.
Comment 2 Nat Makarevitch 2007-01-28 19:46:43 UTC
(Note: the article is 'Golden ratio')

Trying to access to the URL associated to this bug seems not possible ('Read
Timeout' error) with Iceweasel (Firefox) 2.0.0.1 (Debian x86 package:
2.0.0.1+dfsg-2) and lynx (2.8.5-2sarge2.), either loged under a WP account or as
anon.
Comment 3 Derk-Jan Hartman 2010-05-21 19:33:27 UTC
I get a 500 error, because on of the revisions in question does not appear to be available.

http://en.wikipedia.org/w/index.php?title=Golden_ratio&oldid=44320111

Perhaps this is due to bug 20757 ?
Comment 4 Platonides 2010-05-28 13:34:36 UTC
> I get a 500 error, because on of the revisions in question does not appear to
> be available.
> 
> http://en.wikipedia.org/w/index.php?title=Golden_ratio&oldid=44320111
>
> Perhaps this is due to bug 20757 ?

No. The revision text is available 
http://en.wikipedia.org/w/index.php?title=Golden_ratio&oldid=44320111&action=edit

As Nat points out, that seems parser related.

You can view the diff with http://en.wikipedia.org/w/index.php?title=Golden_ratio&diff=44320111&oldid=44319915&diffonly=1
Comment 5 Platonides 2010-05-28 13:52:50 UTC
That line produces:
PHP Fatal error:  Balloc() allocation exceeds list boundary in includes/parser/Parser.php on line 737

where the relevant lines are:

		foreach ( $lines as $outLine ) {
			$line = trim( $outLine );

			if ( $line == '' ) { # empty line, go to next line
				$out .= $outLine."\n";
				continue;
			}

The error seems to be comparing a numeric string of 2000016 characters ($line) with the empty string with the == equal. It is fixed by doing a strict comparison (===). Then the error moves at a different point.
Comment 6 Platonides 2010-05-28 14:18:48 UTC
Fixed in r67014

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links