Last modified: 2007-01-14 22:50:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10594, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 8594 - Special:ExpandTemplates outputs invalid XHTML


Summary:	Special:ExpandTemplates outputs invalid XHTML

Status:	RESOLVED FIXED

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	ExpandTemplates (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal normal with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://validator.w3.org/check?uri=htt...
Whiteboard:
Keywords:	easy, patch

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-01-11 22:30 UTC by Mormegil
Modified:	2007-01-14 22:50 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch for the described problems (20.39 KB, patch) 2007-01-11 22:31 UTC, Mormegil	Details
Add an attachment (proposed patch, testcase, etc.)

Description Mormegil 2007-01-11 22:30:24 UTC

HTML code generated by Special:ExpandTemplates is not valid as it does not quote attribute values 
for "rows", does not specify required "cols" attribute, uses "POST" instead of "post" as the form 
method, and does not specify a value for "disabled" attribute.

Also, the default messages include <nowiki> tags which are not interpreted properly, but output 
verbatim, which makes for another XHTML error.

Comment 1 Mormegil 2007-01-11 22:31:42 UTC

Created attachment 3048 [details]
Patch for the described problems

A fix would be simple, something like this should be enough...

Comment 2 Brion Vibber 2007-01-11 22:59:48 UTC

Can you minimize the patch? This seems to include a lot of unrelated
localization changes.

Comment 3 Mormegil 2007-01-12 08:40:40 UTC

It does not, the messages need to be also fixed because of the above mentioned
<nowiki> problem (read the linked validator output). I have only replaced all
<nowiki>{{</nowiki> with &#x7b;{.

Comment 4 Rob Church 2007-01-14 22:50:58 UTC

Fixed in r19266.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links