Last modified: 2007-01-14 22:50:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8594 - Special:ExpandTemplates outputs invalid XHTML
Special:ExpandTemplates outputs invalid XHTML
Product: MediaWiki extensions
Classification: Unclassified
ExpandTemplates (Other open bugs)
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch
Depends on:
  Show dependency treegraph
Reported: 2007-01-11 22:30 UTC by Mormegil
Modified: 2007-01-14 22:50 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch for the described problems (20.39 KB, patch)
2007-01-11 22:31 UTC, Mormegil

Description Mormegil 2007-01-11 22:30:24 UTC
HTML code generated by Special:ExpandTemplates is not valid as it does not quote attribute values 
for "rows", does not specify required "cols" attribute, uses "POST" instead of "post" as the form 
method, and does not specify a value for "disabled" attribute.

Also, the default messages include <nowiki> tags which are not interpreted properly, but output 
verbatim, which makes for another XHTML error.
Comment 1 Mormegil 2007-01-11 22:31:42 UTC
Created attachment 3048 [details]
Patch for the described problems

A fix would be simple, something like this should be enough...
Comment 2 Brion Vibber 2007-01-11 22:59:48 UTC
Can you minimize the patch? This seems to include a lot of unrelated
localization changes.
Comment 3 Mormegil 2007-01-12 08:40:40 UTC
It does not, the messages need to be also fixed because of the above mentioned
<nowiki> problem (read the linked validator output). I have only replaced all
<nowiki>{{</nowiki> with &#x7b;{.
Comment 4 Rob Church 2007-01-14 22:50:58 UTC
Fixed in r19266.

Note You need to log in before you can comment on or make changes to this bug.