Last modified: 2007-01-09 14:05:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8549 - Wrap periods after change size in changes lists in a CSS span
Wrap periods after change size in changes lists in a CSS span
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-09 03:32 UTC by Mark Clements (HappyDog)
Modified: 2007-01-09 14:05 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to move periods inside span tag (1.55 KB, patch)
2007-01-09 03:35 UTC, Mark Clements (HappyDog)
Details
Patch to wrap periods in span tag (1.29 KB, patch)
2007-01-09 04:08 UTC, Mark Clements (HappyDog)
Details

Description Mark Clements (HappyDog) 2007-01-09 03:32:22 UTC
If you decide to hide the byte difference from recent changes by using...

 .mw-plusminus-pos, .mw-plusminus-neg, .mw-plusminus-null { display: none; }

...the periods that separate it from the surrounding text are still displayed.

Without CSS:

  (diff) (hist) . . MyPage; 04:30 . . (-134) . . TheUser (Talk)

With CSS display:none:

  (diff) (hist) . . MyPage; 04:30 . .  . . TheUser (Talk)

Expected display with CSS display:none:

  (diff) (hist) . . MyPage; 04:30 . . TheUser (Talk)

I have created a patch for this, which I will upload now.
Comment 1 Mark Clements (HappyDog) 2007-01-09 03:35:17 UTC
Created attachment 3038 [details]
Patch to move periods inside span tag
Comment 2 Titoxd 2007-01-09 03:42:44 UTC
If the periods are moved within the span, then declaring a color for the span
(as done currently on en.wp) will cause the colors to be colored as well.
Comment 3 Mark Clements (HappyDog) 2007-01-09 03:47:45 UTC
That's a good point, any suggestions?  

How about wrapping the dots in a span tag?

<span class="mw-plusminus-dots"> . . </span>
Comment 4 Mark Clements (HappyDog) 2007-01-09 04:08:31 UTC
Created attachment 3039 [details]
Patch to wrap periods in span tag

Alternative patch to wrap periods in span tag as described in comment 3.

The previous patch was incomplete (the periods were only removed from one call)
and broken (there was a call that didn't add periods) so I'm obsoleting it.
Comment 5 Mark Clements (HappyDog) 2007-01-09 14:05:48 UTC
Please can you explain why this is invalid?  The problem is there as described.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links