Last modified: 2011-07-24 11:40:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8498 - 'cur' link in article history should have 'diff=cur'
'cur' link in article history should have 'diff=cur'
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-01-05 07:23 UTC by Carlos
Modified: 2011-07-24 11:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Quickie patch (434 bytes, patch)
2008-12-23 01:47 UTC, Brion Vibber
Details

Description Carlos 2007-01-05 07:23:17 UTC
Currently, the 'cur' link in an article history has the form
  diff=nnnn&oldid=mmmm

where mmmm is the revision id of the current row's edit, and nnnn is the
revision id of the first row's edit.

I think nnnn should be always 0 (or "cur"). If the history page I'm viewing is
obsolete because someone added or deleted revisions between the time I loaded
the page and now, I still should get the diff between the current row and the
last revision (even if it isn't listed in the page).

Thanks.
Comment 1 Carlos 2007-01-05 17:47:41 UTC
> I still should get the diff between the current row and the
> last revision (even if it isn't listed in the page).

I meant "between the current and the last revision".
Comment 2 Carlos 2007-01-05 17:49:54 UTC
Ugh... it was correct already. Apparently I can't understand my own broken
English. Forget the last comment (and this). Sorry for the noise.
Comment 3 Brion Vibber 2008-12-23 01:47:31 UTC
Created attachment 5613 [details]
Quickie patch

Hmm... this is a pretty easy change, but I am a little leery -- if you copy-and-paste the link to share w/ other editors it'll show different things as time goes on, so it's not a stable link.
Comment 4 Splarka 2008-12-23 02:04:56 UTC
As it existed in older versions with diff=0, stability was definitely a problem.

Some ideas:
* Add the (cur) link to the generated diff itself, thus removing the need to have it on the history page. Possibly near "previous" "next" links (as show for non-top diffs). Maybe even a media player type set of 4 buttons "first, previous, next, latest".
* Keep the data, that is keep the oldid= and diff= URL parameters as is, but override it with another parameter, such as cur=true. This would allow a link to work as expected. But for pasted/old examples, it could be reverse engineered by removing this parameter (as per similar situation with &curid=1 and &redlink=1, that override default behavior) to see what was seen originally.
Comment 5 Mike.lifeguard 2009-03-17 19:46:11 UTC
(In reply to comment #3)
> Created an attachment (id=5613) [details]
> Quickie patch
> 
> Hmm... this is a pretty easy change, but I am a little leery -- if you
> copy-and-paste the link to share w/ other editors it'll show different things
> as time goes on, so it's not a stable link.
> 

Yes, this is a common problem with the link in the new messages bar. However, the 'cur' links /are/ explicitly against the current revision - if you want a diff between this and that revision, then you can get it with the radio buttons.
Comment 6 Aaron Schulz 2009-07-27 05:44:31 UTC
(In reply to comment #3)
> Created an attachment (id=5613) [details]
> Quickie patch
> 
> Hmm... this is a pretty easy change, but I am a little leery -- if you
> copy-and-paste the link to share w/ other editors it'll show different things
> as time goes on, so it's not a stable link.
> 

Tempted to wontfix
Comment 7 p858snake 2011-04-30 00:09:45 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 8 Dan Collins 2011-07-12 04:51:55 UTC
Since Aaron Schulz and Brion are both tempted to wontfix, and since it would appear that no fix has been implemented, I'm going to actually do that. I would think that in most situations, when you're trying to share a link with another editor, you're more interested in a link to a diff that won't change, rather than one that remains current, and in the latter case, you can always manually edit the URL, it's a trivial edit. On the other hand, static diffs between any revision and current can be created using the radio buttons, as Mike.lifeguard said, but on the other hand once again, that only applies if the revision is on the same page as the current revision, after the first page, the cur links are the only way to do that.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links