Last modified: 2007-01-08 19:13:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8395 - Changes to includes/Parser.php in MediaWiki1.9 are breaking DPLforum
Changes to includes/Parser.php in MediaWiki1.9 are breaking DPLforum
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.9.x
PC Linux
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/wiki/DPLforum
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-26 21:06 UTC by Carl Austin Bennett
Modified: 2007-01-08 19:13 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carl Austin Bennett 2006-12-26 21:06:32 UTC
It appears that upgrading a MediaWiki 1.8 installation to 1.9-svn will break
operation of extensions such as DPLforum 2.1.1 extension, even if they had been
working properly under 1.8

The errors occur in the call to getMaxIncludeSize() in includes/Parser.php, line
2772 in the current version:

        function replaceVariables( $text, $args = array(), $argsOnly = false ) {
                # Prevent too big inclusions
                if( strlen( $text ) > $this->mOptions->getMaxIncludeSize() ) {
                       return $text;
                }

Comment out that one if/return and the wiki (with the extension) becomes usable
again. 

On access to any page with the <forum> tag, symptom is just a blank screen -
error logs indicate the code breaks as this one test fails with:

[Tue Dec 26 13:47:04 2006] [error] [client 127.0.0.1] PHP Fatal error:  Call to
a member function getMaxIncludeSize() on a non-object in
/var/www/html/test/includes/Parser.php on line 2772

So changes made to core code are breaking things elsewhere. :(
Comment 1 Rob Church 2006-12-26 21:13:35 UTC
After a quick read-through of the extension code itself, I rather suspect that
this breakage is due to the extension's authoring being somewhat out of date; it
seems to be declaring new parsers within parse runs, interacting with the global
parser within said runs, interacting with globals such as $wgUser when it should
be referring to the ParserOptions of the parent parser, etc. To be honest, I'm
not surprised it's broken.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links