Last modified: 2010-06-21 17:29:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8174 - Introduce EndOfEditForm hook
Introduce EndOfEditForm hook
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
: 8180 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-06 18:03 UTC by Seth Frey
Modified: 2010-06-21 17:29 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Seth Frey 2006-12-06 18:03:48 UTC
I added a line to autosubmit forms on the editpage (part of my hack for
automated page creation).  I called it 'EndOfEditForm' and put it 'around' line
1200 of EditPage.php between the closing brace and 
             $wgOut->addHTML( "</form>\n" );  


to end up like this:

}                                                                              
                                                                               
                                                                               
               
wfRunHooks('EndOfEditForm');                                                   
                                                                               
                                                                               
                                                            
$wgOut->addHTML( "</form>\n" );    


This is my first bug report, and first big coding project, so if there is any
more standard format I should follow (The essay was more about higher level
concerns, like not being dumb) don't hesitate to let me know.
Comment 1 Rob Church 2006-12-07 01:39:14 UTC
I read "hack for automated page creation", and I'm wondering whether or not the
right approach was used in the first place. Nevertheless,

1. Please submit patches as unified diffs against the latest code in Subversion,
attached to the relevant bug report
2. There are some notes on coding conventions in docs/design.txt
3. The hook would be more useful to other developers if it passed the edit form
object, or at least some extra information, to hook functions
Comment 2 Rotem Liss 2006-12-07 16:17:46 UTC
*** Bug 8180 has been marked as a duplicate of this bug. ***
Comment 3 Rob Church 2006-12-23 13:15:58 UTC
Point 3 was not addressed, so I'm closing this one for later - without extra
information, most hooks aren't useful.
Comment 4 Max Semenik 2010-06-21 17:29:30 UTC
Implemented with EditFormInitialText and friends now. If something else is needed, please open another feature request.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links