Last modified: 2007-05-09 22:45:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8133 - Allow several edits to be undone
Allow several edits to be undone
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.8.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-03 10:45 UTC by Lupin
Modified: 2007-05-09 22:45 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
DiffEng: change Undo link construction for undoing several edits (2.09 KB, patch)
2006-12-14 21:25 UTC, Aaron Schulz
Details
EditPage: Undo uses two params now; can revert several edits (2.12 KB, patch)
2006-12-14 21:26 UTC, Aaron Schulz
Details
Update editpage; change summary schema (2.39 KB, patch)
2006-12-14 22:35 UTC, Aaron Schulz
Details
Update; DiffEng, remove undo links from top diffs (2.13 KB, patch)
2006-12-15 02:46 UTC, Aaron Schulz
Details
DiffEng; put undo links back on top diffs (2.09 KB, patch)
2006-12-20 00:46 UTC, Aaron Schulz
Details
Last part of attachment 2868, which wasn't applied (815 bytes, patch)
2007-05-09 22:24 UTC, Platonides
Details

Description Lupin 2006-12-03 10:45:21 UTC
Clicking undo from a page showing the diff for non-consecutive revisions should
attempt to undo the cumulative effect of all of the intervening edits, not
merely the final edit.

For example, consider an article with four consecutive revisions, r1,r2,r3,r4.
If I view the diff page for diff(r2,r3) I can currently hit undo to try to patch
r4 with diff(r3,r2). This is good.

However, if I view diff(r1,r3) and hit undo, r4 is still just patched with
diff(r3,r2); that is, only one edit is undone. I think that r4 should be patched
with diff(r3,r1) to undo the cumulative effect of both edits between r1 and r3.
This would be useful if, for example, both of these edits are vandalism.

The current behaviour is also confusing, as the effect of hitting undo does not
correspond with what is displayed on the diff page diff(r1,r3).
Comment 1 Andrew Garrett 2006-12-14 01:00:09 UTC
There's also been talk of removing the (undo) button from multi-revision diffs.
I think this is probably a more sensible option.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-12-14 03:53:11 UTC
I think probably less.  Why drop a potentially handy feature rather than
extending it?
Comment 3 Aaron Schulz 2006-12-14 21:25:06 UTC
Created attachment 2865 [details]
DiffEng: change Undo link construction for undoing several edits
Comment 4 Aaron Schulz 2006-12-14 21:26:01 UTC
Created attachment 2866 [details]
EditPage: Undo uses two params now; can revert several edits
Comment 5 Aaron Schulz 2006-12-14 22:35:10 UTC
Created attachment 2868 [details]
Update editpage; change summary schema

OK, this now uses "undo-summary" language only when one revision was undone and
"undo-summary_set" for muli-edit undoing.

The following can then be added to the en lang stuff:
'undo-summary_set' => 'Undo revisions $1 (by [[Special:Contributions/$3]]) to
$2 (by [[Special:Contributions/$4]])'
Comment 6 Aaron Schulz 2006-12-14 22:35:40 UTC
The other 6 (and later more) langs need updating as well for this to work.
Comment 7 Aaron Schulz 2006-12-15 01:34:16 UTC
Those links above aren't piped...

Actually, for multi edit reverts, the summary should just use regular userpage
links given the cutoff length.
Comment 8 Aaron Schulz 2006-12-15 02:46:02 UTC
Created attachment 2869 [details]
Update; DiffEng, remove undo links from top diffs
Comment 9 Aaron Schulz 2006-12-20 00:46:40 UTC
Created attachment 2908 [details]
DiffEng; put undo links back on top diffs
Comment 10 Aaron Schulz 2007-03-10 23:04:01 UTC
Done in r20317.
Comment 11 Brion Vibber 2007-03-27 21:33:10 UTC
I've reverted that in r20755; it appears to make incompatible changes to the URI
parameters for operating the undo feature, which is:

a) gratuitously annoying

b) would break user JS tools based on it
Comment 12 Aaron Schulz 2007-04-24 02:48:09 UTC
Re-done in r20785.
Comment 13 CBM 2007-05-09 22:21:10 UTC
The automatic edit summary for undoing multiple versions was in the original
attachment 2868 [details] but was never implemented.  Could someone add that in? 
Comment 14 Platonides 2007-05-09 22:24:06 UTC
Created attachment 3609 [details]
Last part of attachment 2868 [details], which wasn't applied
Comment 15 Aaron Schulz 2007-05-09 22:44:37 UTC
Setting backed to fixed, the bug was to enable multi-edit undo and it was done.

Summaries for multi-edit undo must be manual, as any automatic one would just be
to hard to read and be useful.
Comment 16 Aaron Schulz 2007-05-09 22:45:14 UTC
If you want summaries for that anyway, make a new bug report.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links