Last modified: 2007-01-22 01:28:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8131 - [[Special:Oversight]] should have a diff link
[[Special:Oversight]] should have a diff link
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Oversight (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Aaron Schulz
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-12-03 08:07 UTC by Dominic
Modified: 2007-01-22 01:28 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to add diffs to oversight (3.37 KB, patch)
2006-12-08 22:05 UTC, Aaron Schulz
Details
Update; fix bugs, remove need for oversight-id message (3.35 KB, patch)
2006-12-14 02:41 UTC, Aaron Schulz
Details
Update; XHTML comp, remove need for MW messages (3.66 KB, patch)
2006-12-17 08:06 UTC, Aaron Schulz
Details
Update; messages localized like the rest, minor fixes (4.15 KB, patch)
2006-12-20 01:40 UTC, Aaron Schulz
Details
Add "oversight-difference" message (4.21 KB, patch)
2006-12-20 03:13 UTC, Aaron Schulz
Details
Update: fix some things Rob pointed out (4.96 KB, patch)
2006-12-24 09:17 UTC, Aaron Schulz
Details
Fix newlines, more consistant case/spacing use (4.68 KB, patch)
2006-12-24 09:34 UTC, Aaron Schulz
Details
Update; support internationalization (18.02 KB, text/plain)
2006-12-25 04:56 UTC, Aaron Schulz
Details
Update; support internationalization (4.18 KB, patch)
2006-12-25 05:00 UTC, Aaron Schulz
Details
Update HideRevision.i18n - add some french bits (1.94 KB, patch)
2006-12-25 05:01 UTC, Aaron Schulz
Details
Update HideRevision.i18n - add some needed messeges (2.27 KB, patch)
2006-12-25 05:08 UTC, Aaron Schulz
Details
Use LinkObject correctly for usern links (3.87 KB, patch)
2006-12-29 21:02 UTC, Aaron Schulz
Details
Unified diff (6.14 KB, patch)
2007-01-06 04:51 UTC, Aaron Schulz
Details
Update (7.88 KB, patch)
2007-01-18 05:18 UTC, Aaron Schulz
Details
Fix one fr message (8.14 KB, patch)
2007-01-21 02:22 UTC, Aaron Schulz
Details

Description Dominic 2006-12-03 08:07:27 UTC
[[Special:Oversight]] should show diffs as well as a revisions so that we can
see what was changed and easily locate what the offending material was that was
hidden.
Comment 1 Aaron Schulz 2006-12-08 22:05:01 UTC
Created attachment 2841 [details]
Patch to add diffs to oversight

This patch show the diff (if possible) of the hidden revision to last remaining
revision before it. If this revision was the first or the page was archived, it
returns an MediaWiki message error. 

This is not a high-traffic area, so no caching is called.

Here are the MW: messages used:
*oversight-header - page explanation...blah
*oversight-nodiff - diff can't be made, first or page deleted
*oversight-difference - "(Difference from previous remaining revision)"
*oversight-id - "(Previous ID="
*oversight-prev - "last previous revision"
*oversight-hidden - "hidden revision"
Comment 2 Aaron Schulz 2006-12-14 02:41:29 UTC
Created attachment 2863 [details]
Update; fix bugs, remove need for oversight-id message
Comment 3 Aaron Schulz 2006-12-17 08:06:29 UTC
Created attachment 2889 [details]
Update; XHTML comp, remove need for MW messages
Comment 4 Brion Vibber 2006-12-20 01:00:24 UTC
Haven't tested, but some comments from first reading:

+	$compare = $wgRequest->getIntOrNull( 'compare' );
+	if ( $compare == 1 && !is_null( $revision )) {

Since the value of the compare parameter isn't used, you should probably just
use getCheck and a nice true/false comparison.

Or actually, it might be better to use 'diff' and 'oldid' parameters in a way
that's more consistent with regular diffs.

+	$wgOut->addHtml( 'Below is a list of revisions permanantly hidden from public
view.<br></br>

Above is not localized and, bad HTML.
Set it up as a message, add it as wikitext, and use <br/> if it's necessary to
use a br.

+		$text = strval( $rev->getText() );
...
+	    if (strlen($text) < 1) {
+		$wgOut->addHtml(wfmsg('hiderevision-error-missing')); 
+		} else {

This is incorrect; revisions may legitimately be zero-length strings.
For error conditions, check for null (?) return values.

[Also there's some funky whitespace and inconsisent case on the function name here.]

+			"<p>Unable to track changes as there is currently no previous revision for
the page. Either:</p><ul>" .
[snip]

Text not localized; move these to messages, preferably wiki-format.

Comment 5 Aaron Schulz 2006-12-20 01:40:13 UTC
Created attachment 2909 [details]
Update; messages localized like the rest,  minor fixes

It now uses &diff=(0 or 1) to denote comparisons, and uses getCheck to make a
true/false comparison. Revisions error check for null rather than blank revs.
Comment 6 Aaron Schulz 2006-12-20 03:13:27 UTC
Created attachment 2910 [details]
Add "oversight-difference" message
Comment 7 Aaron Schulz 2006-12-24 09:17:02 UTC
Created attachment 2932 [details]
Update: fix some things Rob pointed out
Comment 8 Aaron Schulz 2006-12-24 09:34:15 UTC
Created attachment 2934 [details]
Fix newlines, more consistant case/spacing use
Comment 9 Aaron Schulz 2006-12-25 04:56:50 UTC
Created attachment 2946 [details]
Update; support internationalization
Comment 10 Rob Church 2006-12-25 04:58:14 UTC
Comment on attachment 2946 [details]
Update; support internationalization

This isn't a patch; it's a full file.
Comment 11 Aaron Schulz 2006-12-25 05:00:27 UTC
Created attachment 2947 [details]
Update; support internationalization

Wrong file, I just noticed that when I clicked [diff]
Comment 12 Aaron Schulz 2006-12-25 05:01:21 UTC
Created attachment 2948 [details]
Update HideRevision.i18n - add some french bits
Comment 13 Aaron Schulz 2006-12-25 05:08:32 UTC
Created attachment 2949 [details]
Update HideRevision.i18n - add some needed messeges
Comment 14 Rob Church 2006-12-28 16:04:20 UTC
I don't quite understand the changing of two instances of $skin->makeLinkObj()
to $skin->makeKnownLinkObj() - these will cause false bluelinks when the pages
don't exist.
Comment 15 Aaron Schulz 2006-12-29 21:02:07 UTC
Created attachment 2982 [details]
Use LinkObject correctly for usern links
Comment 16 Aaron Schulz 2007-01-06 04:51:18 UTC
Created attachment 3012 [details]
Unified diff
Comment 17 Aaron Schulz 2007-01-18 05:18:11 UTC
Created attachment 3086 [details]
Update

Secure form more, remove commented out line, some Msg changes.
Comment 18 Aaron Schulz 2007-01-21 02:22:56 UTC
Created attachment 3102 [details]
Fix one fr message
Comment 19 Aaron Schulz 2007-01-22 01:28:14 UTC
Done in r19543

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links