Last modified: 2007-07-17 17:17:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T10054, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 8054 - Redirect user to Special:Search when blank search performed
Redirect user to Special:Search when blank search performed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-11-27 18:42 UTC by Dan Jacobson
Modified: 2007-07-17 17:17 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dan Jacobson 2006-11-27 18:42:25 UTC
If the user doesn't enter anything into the box before pressing
"Search", take him to [[Special:Search]], instead of the Main Page.
Comment 1 Robert Leverington 2006-11-27 20:59:53 UTC
I agree this is much more intuitive and I find myself using the search button all 
the time to get to the search page and ending up at the main page.
Comment 2 David Augusto Villa 2006-12-31 08:31:48 UTC
First I'm new here, but please explain. I press Go or Search on Wikipedia and 
Wiktionary and it already directs to the search page. It would be very nice though to 
be able to restrict the namespaces from that page. Right now you have to do whatever 
you've defined as your default search (or the default for default searches for those 
who haven't edited their preferences) which is annoying when the servers are 
overloaded. Is this comment mis-placed?
Comment 3 Brion Vibber 2006-12-31 08:34:23 UTC
David, I see what you mean; go ahead and enter a new bug for that issue.
This bug will be closed once we work out the original complaint, which is separate,
so it's best to keep them apart for individual tracking.
Comment 4 David Augusto Villa 2006-12-31 09:19:49 UTC
Bug 8444 submitted. ~~~~
Comment 5 Brion Vibber 2006-12-31 09:28:14 UTC
As a guess, the problem is that the action URL on the skin's mini search form
points directly at the Special:Search page. When using query-string based
$wgArticlePath, this means the title is lost during form submission, as it's
replaced with the form's fields on the GET request.

Possible fixes:
* change Wiki.php to accept a set, but empty 'search' parameter as valid to send
on to Special:Search behind the scenes
* change skin so search form uses $wgScript and passes Special:Search in title
parameter

The first will not change URLs on existing wikis using pretty urls (pathinfo
titles) but will continue to spit out arguably wrong code for ugly urls (query
string titles).

The second will change search URLs to be slightly uglier on pretty-url wikis,
but they'll work more reliably all around. This also avoids the not uncommon
problem with rewrite rules being set up that overwrite the query string, as that
breaks the pretty URLs to Special:Search by ignoring the search parameters.

The two proposed fixes are also not mutually exclusive; they could both be done,
as both are arguably correct and orthogonal.
Comment 6 Brion Vibber 2007-07-17 17:17:30 UTC
Fixed in r24207. Now checking for presence of the parameter, even if it's blank.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links