Last modified: 2007-04-17 07:37:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 8010 - installing the extension breaks regression testing.
installing the extension breaks regression testing.
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Markus Krötzsch
: patch, patch-need-review
: 9335 (view as bug list)
Depends on:
Blocks: 8390
  Show dependency treegraph
 
Reported: 2006-11-22 16:52 UTC by Steve Sanbeg
Modified: 2007-04-17 07:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to defer initialisation (4.75 KB, patch)
2006-11-22 16:54 UTC, Steve Sanbeg
Details

Description Steve Sanbeg 2006-11-22 16:52:02 UTC
Simply installing this extension breaks all regression testing.  This is
beacause the extension does a lot of work when the module is loaded, and none
when it is initialised; including making SQL queries for things that won't be in
the regression test DB.
Comment 1 Steve Sanbeg 2006-11-22 16:54:17 UTC
Created attachment 2757 [details]
patch to defer initialisation

This patch moves most of the initialisation into a swmfInit function, and
defines a few globals that are needed for it to work.  It's been lightly
tested, to ensure that it loads correctly and doesn't mess up regresssion
tests.

I don't know if it's possible yet to regression test the extension, though.
Comment 2 Rob Church 2007-03-19 08:12:57 UTC
*** Bug 9335 has been marked as a duplicate of this bug. ***
Comment 3 Markus Krötzsch 2007-03-24 17:54:29 UTC
The current version almost fixes this, since it abolishes SMWLocalSettings.php
and reduces enabling of the extension to a single function call. I will take
care of moving this into the extensionfunction hook as well.

Also, we are about to move to a complete storage abstraction achitecture, which
replaces virtually all specific SQL calls by calls to one storage accessing
object. Implementing a dummy or testing object with the same interface would
enable some sort of regression testing even without an initialised database.
Comment 4 Markus Krötzsch 2007-04-13 07:04:41 UTC
SMW now does all initialisation in the extension hook, and does no longer
require any patching of MW or any addtional configuration file (was:
"SMWLocalSettings"). There should not be SQL queries during initialisation --
please report this as a bug if it occurs again.
Comment 5 Markus Krötzsch 2007-04-17 07:37:38 UTC
SMW can now be run with a fully virtual store by setting the following in
LocalSettings (after including SMW_Settings.php):

 $smwgDefaultStore = SMW_STORE_TESTING;

This will prevent any undesired DB access, and enables parser testing without
crashes. This setting might be done automatically during parser tests in the
future (if there is a way to find out that we are running within such a test).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links