Last modified: 2007-11-30 15:42:40 UTC
When performing cache checks for localization files, both
self::isLocalisationOutOfDate( $cache ) and a foreach loop comparing filemtime
of the dependencies are done. This appears to be redundant, as
isLocalisationOutOfDate appears to do the same process, and the $expired
variable does not appear to be used.
If they are not actually redundant, recommend adding a comment as to the
function of the code block. I do not have a working memcached extension so I
The discrepancy manifested in trunk on r15823 when Tim Starling merged in the
localisation-work branch. The switch to the isLocalisationOutOfDate appeared to
have happened r15804, and replaced the $expired variable, strongly suggesting
that yes, this was an oversight on Tim Starling's part.
It is unlikely that this has caused significant performance degradation.
Created attachment 2735 [details]
Removes redundant code
Patch that removes the redundant code
blocks #700 : code quality