Last modified: 2006-12-04 09:27:20 UTC
The current tactic to set the return value to false to indicate that something went wrong is (at least in my opinion) a "Bad thing", following patch implements better (IMO) Exception handling. As I'm lazy, this patch will depend on bug 6068, as I'm to lazy to remove those from the patch.
Created attachment 2720 [details] the patch the patch as promised
Created attachment 2721 [details] the patch removed the parts that is designated to the other bug
Created attachment 2723 [details] the patch made the changes brion pointed out.
Created attachment 2727 [details] the patch forgot to fix the space -> tab problem in ParserFunctions.php also (had some strangle rules in .vimrc that was hidden in the bottom)
Created attachment 2732 [details] the better and cleaner patch
it blocks because of the patches are dependent
Don't post patches that depend upon each other, it makes reviewing code changes harder. You've been advised about this before. Thanks.
(In reply to comment #7) > Don't post patches that depend upon each other, it makes reviewing code changes > harder. You've been advised about this before. Thanks. I was told by brion to do so, so please don't complain.
Of course, the correct response to that would have been a quick email, "Hey dude, Brion asked me to...blah blah blah".
(In reply to comment #9) > Of course, the correct response to that would have been a quick email, "Hey > dude, Brion asked me to...blah blah blah". Oh, I'm sorry, I'll think about that next time.
Fixed in r17818
