Last modified: 2006-12-04 09:27:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 7964 - Better errorhandling in ExprParser
Better errorhandling in ExprParser
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: need-parsertest, patch, patch-need-review
Depends on:
Blocks: code_quality 6068
  Show dependency treegraph
 
Reported: 2006-11-17 23:04 UTC by Carl Fürstenberg
Modified: 2006-12-04 09:27 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
the patch (34.92 KB, patch)
2006-11-17 23:04 UTC, Carl Fürstenberg
Details
the patch (29.99 KB, patch)
2006-11-17 23:34 UTC, Carl Fürstenberg
Details
the patch (18.68 KB, patch)
2006-11-17 23:51 UTC, Carl Fürstenberg
Details
the patch (19.96 KB, patch)
2006-11-18 13:00 UTC, Carl Fürstenberg
Details
the better and cleaner patch (13.03 KB, patch)
2006-11-18 17:06 UTC, Carl Fürstenberg
Details

Description Carl Fürstenberg 2006-11-17 23:04:31 UTC
The current tactic to set the return value to false to indicate that something
went wrong is (at least in my opinion) a "Bad thing", following patch implements
better (IMO) Exception handling. 

As I'm lazy, this patch will depend on bug 6068, as I'm to lazy to remove those
from the patch.
Comment 1 Carl Fürstenberg 2006-11-17 23:04:58 UTC
Created attachment 2720 [details]
the patch

the patch as promised
Comment 2 Carl Fürstenberg 2006-11-17 23:34:38 UTC
Created attachment 2721 [details]
the patch

removed the parts that is designated to the other bug
Comment 3 Carl Fürstenberg 2006-11-17 23:51:48 UTC
Created attachment 2723 [details]
the patch

made the changes brion pointed out.
Comment 4 Carl Fürstenberg 2006-11-18 13:00:21 UTC
Created attachment 2727 [details]
the patch

forgot to fix the space -> tab problem in ParserFunctions.php also (had some
strangle rules in .vimrc that was hidden in the bottom)
Comment 5 Carl Fürstenberg 2006-11-18 17:06:57 UTC
Created attachment 2732 [details]
the better and cleaner patch
Comment 6 Carl Fürstenberg 2006-11-18 22:47:51 UTC
it blocks because of the patches are dependent
Comment 7 Rob Church 2006-11-18 23:51:43 UTC
Don't post patches that depend upon each other, it makes reviewing code changes
harder. You've been advised about this before. Thanks.
Comment 8 Carl Fürstenberg 2006-11-19 12:23:53 UTC
(In reply to comment #7)
> Don't post patches that depend upon each other, it makes reviewing code changes
> harder. You've been advised about this before. Thanks.

I was told by brion to do so, so please don't complain.
Comment 9 Rob Church 2006-11-19 12:27:06 UTC
Of course, the correct response to that would have been a quick email, "Hey
dude, Brion asked me to...blah blah blah".
Comment 10 Carl Fürstenberg 2006-11-19 12:42:54 UTC
(In reply to comment #9)
> Of course, the correct response to that would have been a quick email, "Hey
> dude, Brion asked me to...blah blah blah".

Oh, I'm sorry, I'll think about that next time.
Comment 11 Carl Fürstenberg 2006-12-04 09:27:20 UTC
Fixed in r17818

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links