Last modified: 2006-10-29 18:17:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9745, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 7745 - Search button has no id
Search button has no id
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.9.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-10-29 11:36 UTC by Robert Leverington
Modified: 2006-10-29 18:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Adds id to search button in MonoBook.php (12.27 KB, patch)
2006-10-29 12:17 UTC, Robert Leverington 		Details
Patch in unified diff format (705 bytes, patch)
2006-10-29 12:20 UTC, Andrew Garrett 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Robert Leverington 2006-10-29 11:36:41 UTC 
The search button has no id which makes it difficult to customize using user
css. All it needs is an id="something" adding and it will be fixed. The go
button already has one.
Comment 1 Robert Leverington 2006-10-29 12:11:10 UTC 
BTW this is in the monobook skin.
Comment 2 Robert Leverington 2006-10-29 12:17:53 UTC 
Created attachment 2589 [details]
Adds id to search button in MonoBook.php

Here is the latest version of MonoBook.php but with an id added to the search
button, the id is "searchSearchButon" - I chose that because it uses the same
syntax as for the go button.
Comment 3 Andrew Garrett 2006-10-29 12:20:46 UTC 
Created attachment 2590 [details]
Patch in unified diff format

My version of this patch. Resubmitting because the earlier patch was not in
unified diff format (he still beat me, though!)
Comment 4 Andrew Garrett 2006-10-29 12:21:17 UTC 
Comment on attachment 2589 [details]
Adds id to search button in MonoBook.php

Obsoleting old attachment
Comment 5 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-10-29 18:17:47 UTC 
New id's/classes should be prefixed with mw- to avoid conflicts with
user-specified stuff.  Also, Cologne Blue is already using "mw-searchButton", so
I went with that.  Fixed in r17289.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links