Last modified: 2007-03-23 17:59:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 7688 - Anchor links are not helpful on diff view.
Anchor links are not helpful on diff view.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://test.wikipedia.org/w/index.php...
:
: 5080 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-25 09:03 UTC by Nux
Modified: 2007-03-23 17:59 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch that does what Brion suggested. (3.54 KB, patch)
2006-10-25 13:07 UTC, Fyren
Details

Description Nux 2006-10-25 09:03:59 UTC
Hi.

The thing is that anchor links on diff view have a href like
href="/wiki/User:Nux/test#A_section" which is good only on history page and
such. When I actually compare two version e.g.:
http://test.wikipedia.org/w/index.php?title=User%3ANux%2Ftest&diff=9418&oldid=9417
I would expect a section link to simply point me down to the section and not
reload a page to latest version on which this section might have been already
removed.

The solution would be to simply construct links like this:
href="#A_section"

If someone actually use those links on pages like village pump, then fixing this
bug might actually reduce server load.
Comment 1 Nux 2006-10-25 09:05:19 UTC
Oh and by "section link" I mean something like: "(→A section)"
Comment 2 Brion Vibber 2006-10-25 11:59:49 UTC
Linker::formatComment() produces the section autocomment links; since most such are displayed on Recent Changes or 
history views, the link includes the destination page's full URL.

It might be useful to be able to pass another parameter to indicate that the rendered text appears on the page below so a 
local anchor link can be made.
Comment 3 Fyren 2006-10-25 13:07:40 UTC
Created attachment 2555 [details]
Patch that does what Brion suggested.

Added a $local parameter that trickles down from Linker::revComment ->
Linker::commentBlock -> Linker::formatComment.	Doesn't break anything on my
test wiki, at least!
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-17 04:01:03 UTC
Committed in r17741, with a modification: the section link in the "old" diff
summary may not refer to a valid section (could have been removed in the
interim), so the new behavior affects only the "new" diff summary.
Comment 5 Rotem Liss 2006-11-17 11:03:52 UTC
(In reply to comment #4)
> Committed in r17741, with a modification: the section link in the "old" diff
> summary may not refer to a valid section (could have been removed in the
> interim), so the new behavior affects only the "new" diff summary.

I think you changed it 17742, and applied it to the "old" summary as well.
Comment 6 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-17 12:51:48 UTC
Correct, I did do that in r17742, I was just too lazy to note it here.  :D
Comment 7 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-03-23 17:59:15 UTC
*** Bug 5080 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links