Last modified: 2006-10-25 12:55:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9658, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 7658 - mwdump -filter=latest
mwdump -filter=latest
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-10-21 21:15 UTC by Aurimas Fišeras
Modified: 2006-10-25 12:55 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to extend --filter:latest (5.84 KB, patch)
2006-10-21 21:17 UTC, Aurimas Fišeras
Details
Patch to extend --filter:latest (fixed) (4.95 KB, patch)
2006-10-21 21:21 UTC, Aurimas Fišeras
Details
Patch to extend --filter:latest (4.80 KB, patch)
2006-10-22 10:12 UTC, Aurimas Fišeras
Details
mwdump -filter=before:<timestamp> (4.90 KB, patch)
2006-10-24 13:25 UTC, Aurimas Fišeras
Details
mwdump -filter=after:<timestamp> -filter=before:<timestamp> (7.97 KB, patch)
2006-10-25 06:51 UTC, Aurimas Fišeras
Details
mwdump -filter=after:<timestamp> -filter=before:<timestamp> (8.85 KB, patch)
2006-10-25 08:42 UTC, Aurimas Fišeras
Details

Description Aurimas Fišeras 2006-10-21 21:15:28 UTC
Extend this option, by adding the timestamp that changes behavior to:
"Skips all but the last revision before the specified timestamp"
Comment 1 Aurimas Fišeras 2006-10-21 21:17:24 UTC
Created attachment 2532 [details]
Patch to extend --filter:latest

A patch to add such behavior.
Comment 2 Aurimas Fišeras 2006-10-21 21:21:29 UTC
Created attachment 2534 [details]
Patch to extend --filter:latest (fixed)

d'oh
Comment 3 Aurimas Fišeras 2006-10-22 10:12:44 UTC
Created attachment 2535 [details]
Patch to extend --filter:latest

fixed a serious bug.
Comment 4 Brion Vibber 2006-10-24 11:32:04 UTC
It might be cleaner to instead have a 'before' or 'up to' filter that passes *all* revisions up to the given time.
With the latest filter applied after it on the pipe, this would perform the desired function while also being more flexible.
Comment 5 Aurimas Fišeras 2006-10-24 13:25:57 UTC
Created attachment 2547 [details]
mwdump -filter=before:<timestamp>

Good suggestion. Filter rewritten.
You can get the previous effect using these filters:
--filter=latest --filter=before:<timestamp>
Comment 6 Aurimas Fišeras 2006-10-25 06:51:03 UTC
Created attachment 2551 [details]
mwdump -filter=after:<timestamp> -filter=before:<timestamp>

Added:
-filter=after:<timestamp>.

Enables to create possibly useful dumps for statistical analysis, etc.

e.g.:
--filter=after:2004-01-01T00:00:00Z --filter=before:2005-01-01T00:00:00Z
Comment 7 Brion Vibber 2006-10-25 08:23:09 UTC
The two filter classes look identical except for one method call. :)
Duplicated code always increases the risks of bugs being introduced when things are changed;
it would be cleaner to avoid the duplicated code and make these on one base class.
Comment 8 Aurimas Fišeras 2006-10-25 08:42:35 UTC
Created attachment 2553 [details]
mwdump -filter=after:<timestamp> -filter=before:<timestamp>

Properly rewritten.
Comment 9 Brion Vibber 2006-10-25 12:55:54 UTC
Looks good, thanks! Added in r17250.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links