Last modified: 2011-03-13 18:06:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 7451 - "isbn" not a wikilink
"isbn" not a wikilink
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Lowest enhancement (vote)
: ---
Assigned To: Dirk Beetstra
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2006-09-30 10:48 UTC by Dirk Beetstra
Modified: 2011-03-13 18:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch to make the ISBN clickable in the search page (777 bytes, patch)
2006-09-30 10:49 UTC, Dirk Beetstra

Description Dirk Beetstra 2006-09-30 10:48:46 UTC
The word "ISBN" on the search-page is not wikilinked to ISBN, I guess that would be a nice thing to 
have, people trying to find the source of a book (where they can buy their own copy, e.g.), but not 
knowing what the format of the ISBN-number is (now they have to type "ISBN" in the search box).

Comment 1 Dirk Beetstra 2006-09-30 10:49:55 UTC
Created attachment 2423 [details]
Patch to make the ISBN clickable in the search page

Make isbn a wikilink.
Comment 2 Jimmy Collins 2006-09-30 11:32:01 UTC
This will point you to a non existing page in non-Wikipedia environments ...
Comment 3 Dirk Beetstra 2006-09-30 11:37:42 UTC
That is true, but then, either that wikipedia may not be in need of the page (in which case the page can 
be ignored, anyway), or, if that wikipedia is in need of that functionality, I guess the ISBN-page would 
be created anyway.  Or do you suggest a 'if the page exists, then link, otherwise, plain text' (in that 
case, how do I check if a page is a redlink in php)?
Comment 4 Jimmy Collins 2006-09-30 11:43:11 UTC
The the usage of the message 'isbn' should be wikified in
[[Special:Booksources]] so that it could be customized via [[MediaWiki:Isbn]]
where needed.
Comment 5 Dirk Beetstra 2006-09-30 12:01:33 UTC
The current generated form in the SpecialBooksources.php that asks for an ISBN, presumes that the person 
using that page will know what an ISBN is (the person probably comes from the ISBN page anyway, but may 
come from the list of special pages) .. it makes sense to me to make a link on that page to somewhere 
(and I think the "activepedia"-ISBN-page is a logical choice, that one will be adapted by the users to 
the language and text that they want there) where one can read what the ISBN is, and what it looks like, 
If in a non-wikipedia environment the page gets used, then indeed the page [[ISBN]] should be generated 
as well, since otherwise it will be a redlink.  But I presume that will be quick enough, if the page gets 
used regularly on that non-wikipedia-environment.  In the worst case the user gets just as much info 
(nothing) as he/she would get now when using the page.
Comment 6 Jimmy Collins 2006-10-07 15:05:51 UTC
Just add/edit [[MediaWiki:Booksources-summary]] to clarify.
Comment 7 Jimmy Collins 2006-10-07 15:17:51 UTC
Discussed with Dirk in irc - [[MediaWiki:Booksources-summary]] makes this bug

Note You need to log in before you can comment on or make changes to this bug.