Last modified: 2014-11-20 04:55:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75281, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 73281 - Lua syntax highlighting doesn't recognize comments properly
Lua syntax highlighting doesn't recognize comments properly
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: upstream
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-11-11 20:06 UTC by automatik68
Modified: 2014-11-20 04:55 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description automatik68 2014-11-11 20:06:49 UTC
In https://fr.wiktionary.org/wiki/Module:FranceTerme, all the text after the first opening long bracket "[[" is grey, indicating it's a comment, up to the second closing long bracket, instead of the first. However, the module works fine and with CodeEditor, while editing the page, syntax highlighting is fine. Any idea to fix this?
Comment 1 Sam Reed (reedy) 2014-11-11 20:50:52 UTC
Needs filing/fixing upstream at https://github.com/GeSHi/geshi-1.0/issues
Comment 2 George Orwell III 2014-11-13 03:13:34 UTC
Any reason..
 
--[=[
Start of hidden comments
        . . .
End of hidden comments
]=]

... provides the desired detection of the closing of hidden comments long brackets? Could there have been a change in syntax usage since last release was updated or something?

Note: Also confirmed in   https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Module_syntax_highlighting_broken_for_hidden_comments

 .
Comment 3 This, that and the other (TTO) 2014-11-13 11:19:19 UTC
(In reply to Sam Reed (reedy) from comment #1)
> Needs filing/fixing upstream at https://github.com/GeSHi/geshi-1.0/issues

https://github.com/GeSHi/geshi-1.0/issues/32
Comment 4 Brad Jorsch 2014-11-13 14:52:27 UTC
(In reply to George Orwell III from comment #2)
> Any reason..
>  
> --[=[
> Start of hidden comments
>         . . .
> End of hidden comments
> ]=]
> 
> ... provides the desired detection of the closing of hidden comments long
> brackets? Could there have been a change in syntax usage since last release
> was updated or something?

If you have two such blocks in a single module, it shows the same issue. Basically, instead of finding the *first* close-comment after the open-comment, it finds the *last* one.
Comment 5 Gerrit Notification Bot 2014-11-13 21:27:24 UTC
Change 173104 had a related patch set uploaded by TheDJ:
Fix Lua comment blocks and string blocks.

https://gerrit.wikimedia.org/r/173104
Comment 6 Gerrit Notification Bot 2014-11-18 16:27:18 UTC
Change 173104 merged by jenkins-bot:
Fix Lua comment blocks and string blocks.

https://gerrit.wikimedia.org/r/173104
Comment 7 Brad Jorsch 2014-11-18 16:58:09 UTC
This should be deployed to WMF wikis with 1.25wmf9, see https://www.mediawiki.org/wiki/MediaWiki_1.25/Roadmap for the schedule.
Comment 8 George Orwell III 2014-11-20 04:55:38 UTC
Verified - working again!

.... after a cache refresh or two on the test-bed that is.



see: https://test2.wikipedia.org/s/p8u

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links