Last modified: 2014-11-12 14:51:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T75077, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 73077 - Jenkins: Don't trigger rubocop for changes that only modify php or js files
Jenkins: Don't trigger rubocop for changes that only modify php or js files
Status: NEW
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-06 12:19 UTC by Krinkle
Modified: 2014-11-12 14:51 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-11-06 12:19:34 UTC 
Change https://gerrit.wikimedia.org/r/#/c/171326/ shouldn't have to trigger VisualEditor-bundle-rubocop.
Comment 1 Antoine "hashar" Musso (WMF) 2014-11-10 10:12:50 UTC 
Seems we should only trigger it when .rubocop.* or .rb files are changed.

In Zuul something like:

jobs:
 - name: '^.*-rubocop$'
   files: '(^\.rubocop\..*|.*\.rb$)'

The same files: statement would have to be added to any other rubocop jobs defined as non voting in the jobs section. Ie:

  - name: mediawiki-core-bundle-rubocop
    voting: false
+   files: '(^\.rubocop\..*|.*\.rb$)'
Comment 2 Antoine "hashar" Musso (WMF) 2014-11-12 14:51:08 UTC 
Unassigning myself, I am not working on it.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links