Last modified: 2010-05-15 15:41:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 7294 - wrong diff3 location calculation
wrong diff3 location calculation
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.7.x
PC Windows XP
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-09-12 07:18 UTC by Keymone
Modified: 2010-05-15 15:41 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Keymone 2006-09-12 07:18:05 UTC
in /wiki/config/index.php on line 421 wrong operation applied to arrays
on my PHP 5.1.4
$array1 + $array2 cause replacing $array1[0] = $array2[0] and so on
using array_marge($array1,$array2) solves the problem
Comment 1 Andrew Garrett 2006-11-03 03:14:20 UTC
Applying said patch causes running index.php to halt after the following
initialisation sequence of the install page. The patch given appears to break
MediaWiki. WONTFIX.

    * PHP 5.1.6-1 installed
    * Found database drivers for: MySQL
    * PHP server API is apache2handler; ok, using pretty URLs (index.php/Page_Title)
    * Have XML / Latin1-UTF-8 conversion support.
    * PHP's memory_limit is 50M. If this is too low, installation may fail!
    * Have zlib support; enabling output compression.
    * Couldn't find Turck MMCache, eAccelerator or APC. Object caching functions
cannot be used.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2006-11-03 03:23:03 UTC
The concern appears to be correct, regardless of whether the patch is. 
http://www.php.net/manual/en/language.operators.array.php clearly states that
$array1 + $array2 behaves as Keymone says.  array_merge() shouldn't cause any
problems, are you sure that it's not your testing procedure at fault?
Comment 3 Andrew Garrett 2006-11-03 03:25:58 UTC
I tested the "install" procedure twice. I opened config.php once, applied the
patch, and then refreshed config.php. The element at fault is clearly the patch
itself.
Comment 4 Keymone 2006-11-03 05:45:37 UTC
did you looked at resulting array?

$a + $b will be a union only if it's associated array. in case of simple array:

array(1,2,3,4) + array(5,6,7) == array(5,6,7,4)

it's noted in php help also:
http://www.php.net/manual/en/language.operators.array.php

maybe there is another solution for the problem
Comment 5 Brion Vibber 2006-11-03 13:01:48 UTC
Fixed in r17380

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links