Last modified: 2014-11-03 06:45:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74870, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72870 - TitleMoveComplete hook is broken after (ac53e4503)
TitleMoveComplete hook is broken after (ac53e4503)
Status: NEW
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.25-git
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-11-01 21:59 UTC by MWJames
Modified: 2014-11-03 06:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MWJames 2014-11-01 21:59:03 UTC 
Running our integration test [0] against master before the "Fully replace Title::moveTo() with MovePage" [1] merge does return a null revision for a moved page (using "WikiPage::factory( $oldTitle )->getRevision()for verification) but after the merge the old title still has a revision.

This breaks our integration tests for MW 1.25 after [1] while tests before that and those on MW 1.24/MW 1.23/MW 1.21 do work as specified and expected.

[0] SMW\Tests\Integration\MediaWiki\Hooks\TitleMoveCompleteIntegrationTest::testPageMoveWithCreationOfRedirectTarget

Failed asserting that null is not null.

[1] https://github.com/wikimedia/mediawiki/commit/ac53e45035e7b7ea22e123b404608e5e699024be
Comment 1 Andre Klapper 2014-11-03 06:44:35 UTC 
Ic5026384b92a0d68d628397ffe1de6e5b6183f02
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links