Last modified: 2014-11-19 22:14:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T74816, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 72816 - VisualEditor: Tables - adding formatted headings to <visualeditor-table-caption> displays Uncaught TypeError
VisualEditor: Tables - adding formatted headings to <visualeditor-table-capt...
Status: VERIFIED FIXED
Product: VisualEditor
Classification: Unclassified
ContentEditable (Other open bugs)
unspecified
All All
: Low normal
: VE-deploy-2014-11-12 (1.25wmf8)
Assigned To: Ed Sanders
:
Depends on:
Blocks: ve-tablesupport
  Show dependency tree / graph
 
Reported: 2014-10-31 16:05 UTC by etonkovidova
Modified: 2014-11-19 22:14 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description etonkovidova 2014-10-31 16:05:55 UTC 
1. In VE highlight any portion of an inserted table and add <visualeditor-table-caption>.  

2. Without typing any text in the caption, select any format for headings format - Uncaught TypeError will be displayed.

Uncaught TypeError: Cannot read property 'nodeType' of undefined VM8471:495ve.ce.Document.getNodeAndOffset VM8471:495ve.ce.Surface.focus VM8471:538ve.ui.FormatAction.convert VM8471:661ve.ui.Surface.execute VM8471:629ve.ui.Command.execute VM8471:645ve.ui.Tool.onSelect VM8471:638OO.ui.ToolGroup.onPointerUp VM8471:66OO.ui.PopupToolGroup.onPointerUp VM8471:91jQuery.event.dispatch load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20141030T0…:65elemData.handle 

3. Attempt to delete the added caption displays: 

Uncaught Error: Unbalanced set of replace operations found (program):321ve.dm.TransactionProcessor.processors.replace (program):321ve.dm.TransactionProcessor.executeOperation (program):314ve.dm.TransactionProcessor.process (program):314ve.dm.Document.commit (program):390ve.dm.Surface.changeInternal (program):366ve.dm.Surface.change (program):365ve.dm.SurfaceFragment.change (program):370ve.dm.SurfaceFragment.delete (program):380ve.ce.Surface.handleLinearDelete (program):578ve.ce.Surface.onDocumentKeyDown (program):546ve.EventSequencer.callListener (program):257ve.EventSequencer.onEvent (program):254(anonymous function) (program):252jQuery.event.dispatch load.php:65elemData.handle
Comment 1 James Forrester 2014-11-13 12:59:50 UTC 
Fixed in master.
Comment 2 etonkovidova 2014-11-13 20:19:42 UTC 
Verified the fix in test2.
Comment 3 etonkovidova 2014-11-19 22:14:45 UTC 
Verified the fix in production.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links