Last modified: 2014-11-08 00:17:40 UTC
On https://pt.wikipedia.org/wiki/Template:Country_flag_IOC_alias_IRQ?uselang=en I followed these steps: 1. Add links 2. Language: en 3. Page: Template:Country flag IOC alias IRQ 4. Link with page 5. Confirm At this point, a popup appeared with a button "Close dialog and reload page". When I pressed ESC, it reloaded the page instead of just closing the popup.
Change 171868 had a related patch set uploaded by Hoo man: Allow submitting linkItem form with enter https://gerrit.wikimedia.org/r/171868
Accidentally uploaded a change with the wrong bug number.
The page is being refreshed on all popup closes (after successful linking) on purpose, I'm not sure we want to change this. It might be confusing for people to see that their newly added links aren't there.
Why would someone press ESC to ADD something if it is usually used "in dialog boxes for No, Quit, Exit, Cancel, or Abort" https://en.wikipedia.org/w/index.php?title=Esc_key#Uses
(In reply to Helder from comment #4) > Why would someone press ESC to ADD something if it is usually used "in > dialog boxes for No, Quit, Exit, Cancel, or Abort" > https://en.wikipedia.org/w/index.php?title=Esc_key#Uses You can abort/ cancel that action at that point, that should be shown to the user.
(In reply to Helder from comment #4) > Why would someone press ESC to ADD something if it is usually used "in > dialog boxes for No, Quit, Exit, Cancel, or Abort" > https://en.wikipedia.org/w/index.php?title=Esc_key#Uses You can't abort/ cancel that action at that point, that should be shown to the user.
