Last modified: 2010-05-15 15:38:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 727 - Number of watching users per page to be shown on recent changes view (finished)
Number of watching users per page to be shown on recent changes view (finished)
Status: CLOSED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Lowest enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://meta.wikimedia.org/wiki/Email_...
:
Depends on: 454
Blocks: 1932
  Show dependency treegraph
 
Reported: 2004-10-16 18:19 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2004-10-16 18:19:09 UTC
Together with my enotif patch (see
http://bugzilla.wikipedia.org/show_bug.cgi?id=454 ) I introduced the possibility
of having the number of watching users shown next to the page title in the
recent changes view.

A new message page MediaWiki:number_of_watching_users is introduced, which is
preset with '($1 watching user/s)' in module Language.php during fresh or
upgrade installations. 

'$1' is replaced with the number of watching users.
The text is only is only shown, if the number is > 0 .
Comment 1 Jamesday 2004-10-17 01:55:44 UTC
How is the number of watchers cached, for logged in and not logged in viewers?
When it has to be read fromthe database, it read from a database slave?
Watchlist doesn't currently have an efficient key for this (namespace, title is
the closest: too big). Does this add a more efficient non-unique article ID key
so the count can be found in an index which easily fits in cache RAM?
Comment 2 T. Gries 2004-10-17 07:47:17 UTC
(In reply to comment #1)
> How is the number of watchers cached, for logged in and not logged in viewers?
> When it has to be read fromthe database, it read from a database slave?
> Watchlist doesn't currently have an efficient key for this (namespace, title is
> the closest: too big). Does this add a more efficient non-unique article ID key
> so the count can be found in an index which easily fits in cache RAM?

Dear Jamesday, at this moment, I admittedly did not take care about these
efficiency issues and use straight MySQL calls. This stems from the fact, that I
learnt to understand the MediaWiki code since January - in order to implement
enotif - and personally find that there is an inherent lack of documentation,
especially with respect to the cache and other efficiency-improving changes in
the last versions, which makes it difficult for MediaWiki-Developer-newbie to
fulfill _all_ requirement just at the beginning. Now, after having programmed
and checked the functionality, I wish to learn from you how to improve my
ameliorations to the project. Here are my answers, as far as I can give them.

As you perhaps know, I have implemented and published the enoitf patch see
http://bugzilla.wikipedia.org/show_bug.cgi?id=454 and it can be important to get
an indication, how many mails will be sent out (= number of watching users,
currently. Later, as a digest per timezone, see http://meta.wikipedia.org/Enotif ).

The following code sniplet is from the recent enotif 1.21 published on Oct. 16,
2004 (see that bugzilla 454). The enotif is for mw1.3.6 and I currently port the
changes to CVS 1.4 version.

The core of counting the watching numbers is in module SpecialRecentchanges.php:

sql3=SELECT COUNT(*) AS numberofwatchingsusers FROM watchlist WHERE
wl_title={$obj->rc_itle} AND wl_namespace={$obj->rc_namespace}
res3=$dbr->query(sql3)
call recentChangesLine(....., numberofwatchingusers)

And some modifications in recentChangesLineOld and ..New in Skin.php are needed.

Bruce has very early proposed to me to use a new index (namespace+title), which
I perhaps implement soon for watchlist. See the old mail in a top position in my
public to-do list, which is
http://meta.wikimedia.org/wiki/Email_notification_to-do_list#using_namespace_title_as_index_.28as_proposed_here.29

I hope, I have given (a admittedly lenghty, pls. apologize) an explanation,
which I did (first functionality) and what I plan to do (efficiency improvements)

Tom Gries
Berlin
Comment 3 T. Gries 2004-11-04 01:21:02 UTC
The number of watching users is shown on recent changes page, watchlist and
article page footers. 

Enotif versions > 1.32 have this built in and allow any user to disable the
number display. Currently, the numbers are shown in brackets at the last item on
recentchanges lines, such as [5]
Comment 4 Brion Vibber 2004-11-04 01:42:54 UTC
Reopening, as this feature is not (yet) in MediaWiki, but rather in a third-party patch under 
development which has not (yet) been included.
Comment 5 T. Gries 2004-12-19 08:00:38 UTC
Closed now. The display of the number of watching users on recent changes view,
watchlist and article page footers depends on two variables in DefaultSetting.php:

$wgRCShowWatchingUsers (*)
$wgPageShowWatchingUser

(*) User preferences page shows an corresponding option for the user where the
user can opt-out or opt-in. (The option is only shown, if the DefaultSettings
option $wgRCShowWatchingsUsers is true.)

After a fresh installation, both options are disabled. To see the number, you
need to enable one or both (in DefaultSettings.php). As long as the both
variables are set to false, the necessary database requests for retreiving the
number of watching users are skipped.
Comment 6 T. Gries 2005-04-27 23:28:39 UTC
*implemented* in ENotif/EConfirm v3.16, see
http://bugzilla.wikipedia.org/show_bug.cgi?id=454 .

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links