Last modified: 2014-10-09 21:32:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73837, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71837 - VisualEditor: Bring back the edit summary byte counter in the save dialog
VisualEditor: Bring back the edit summary byte counter in the save dialog
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High normal
: VE-deploy-2014-10-16
Assigned To: Sucheta Ghoshal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-10-08 20:28 UTC by Roan Kattouw
Modified: 2014-10-09 21:32 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2014-10-08 20:28:52 UTC
It's ve-ui-mwSaveDialog-editSummary-count in MWSaveDialog, but there are several issues with it:

* It should be stored in a variable, not searched for using jQuery .find() every time
* It should be modified with methods on OO.ui.LabelWidget, not jQuery .text()
* It should actually be visible

I don't know why it's being hidden, but display: none; is set on it, so maybe .hide() is called somewhere?
Comment 1 Gerrit Notification Bot 2014-10-09 20:54:32 UTC
Change 165871 had a related patch set uploaded by SuchetaG:
Bringing back the edit summary byte counter in the save dialog

https://gerrit.wikimedia.org/r/165871
Comment 2 Gerrit Notification Bot 2014-10-09 21:29:49 UTC
Change 165871 merged by jenkins-bot:
Bringing back the edit summary byte counter in the save dialog

https://gerrit.wikimedia.org/r/165871

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links