Last modified: 2014-10-13 10:52:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73729, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71729 - HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined)
HttpRequest: Failing under PHP 5.6 (CURLOPT_CLOSEPOLICY not defined)
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High major (vote)
: 1.25.0 release
Assigned To: Nobody - You can work on this!
: newphp
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-07 03:06 UTC by Krinkle
Modified: 2014-10-13 10:52 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Krinkle 2014-10-07 03:06:15 UTC 
Constants CURLOPT_CLOSEPOLICY, CURLCLOSEPOLICY_LEAST_RECENTLY_USED and others are not defined as they were removed in PHP 5.6.0.

Tests should probably be updated to only test the ones relevant for the CurlHttpRequest class to function properly. If those include constants removed in PHP 5.6, then we should fix the code to use a different method in PHP 5.6.

See also:
* http://php.net/manual/en/curl.constants.php#constant.curlopt-closepolicy
* https://gerrit.wikimedia.org/r/#/c/159159/
* https://bugzilla.wikimedia.org/show_bug.cgi?id=70570

Example of HttpRequest failing on PHP 5.6:
https://travis-ci.org/wikimedia/mediawiki-core/jobs/37159310 (lines 305...342)
Comment 1 Gerrit Notification Bot 2014-10-07 18:19:53 UTC 
Change 162825 had a related patch set uploaded by Dan-nl:
Updated cURL constants array

https://gerrit.wikimedia.org/r/162825
Comment 2 Gerrit Notification Bot 2014-10-07 22:28:16 UTC 
Change 162825 merged by jenkins-bot:
HttpTest: Update cURL constants array

https://gerrit.wikimedia.org/r/162825
Comment 3 Andre Klapper 2014-10-12 18:29:45 UTC 
Anything left to do here, or did the merged patch fix this bug report?
Comment 4 Krinkle 2014-10-13 10:52:26 UTC 
https://travis-ci.org/Krinkle/mediawiki-core/jobs/37801162 (current master on PHP 5.6) no longer shows any CURL related errors.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links