Last modified: 2014-10-09 18:34:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73365, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 71365 - Audio tags shouldn't have height. Look cramped in mobile.
Audio tags shouldn't have height. Look cramped in mobile.
Status: RESOLVED FIXED
Product: MobileFrontend
Classification: Unclassified
stable (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Sam Smith
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-09-26 18:40 UTC by Jon
Modified: 2014-10-09 18:34 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
this problem features on many song articles (144.32 KB, image/png)
2014-09-26 18:40 UTC, Jon 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-09-26 18:40:02 UTC 
Created attachment 16606 [details]
this problem features on many song articles

I'm not sure what creates the audio tags - core or an extension but they shouldn't be styled with fix widths and heights.

expected: it should do it in a stylesheet if necessary for Vector.
Comment 1 Bingle 2014-09-26 18:40:25 UTC 
Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/VZh3nH2X
Comment 2 Sam Smith 2014-10-08 13:57:37 UTC 
The audio tags are created by the TimedMediaTransformOutput class in the TimedMediaHandler extension.

The TimedMediaTransformOutput can create tags for both audio and video elements. My approach will be to remove the inline styling for /audio tags only/ and then create a follow-on bug for dealing with the video tags.
Comment 3 Brion Vibber 2014-10-08 14:00:49 UTC 
See also bug 61823 (ogv.js player integration) -- the last patchset on it adds a mobile media player overlay for audio and video, using ogv.js on Safari or the native <audio>/<video> elements if supported.

However it's bitrotted in the last few weeks and needs updating for current MobileFrontend/Mantle.
Comment 4 Gerrit Notification Bot 2014-10-09 16:42:01 UTC 
Change 165753 had a related patch set uploaded by Phuedx:
Don't give audio tags a height style

https://gerrit.wikimedia.org/r/165753
Comment 5 Gerrit Notification Bot 2014-10-09 18:23:02 UTC 
Change 165753 merged by jenkins-bot:
Don't give audio tags a height style

https://gerrit.wikimedia.org/r/165753
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links