Last modified: 2014-10-20 18:37:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T73131, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 71131 - VisualEditor: [Regression pre wmf1] Math inspector closes each time a character is inserted and it tries to parse it
VisualEditor: [Regression pre wmf1] Math inspector closes each time a charact...
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
Editing Tools (Other open bugs)
unspecified
All All
: High major
: VE-deploy-2014-09-25
Assigned To: Ed Sanders
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-09-22 19:15 UTC by Rummana Yasmeen
Modified: 2014-10-20 18:37 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rummana Yasmeen 2014-09-22 19:15:40 UTC
Steps to reproduce:

1.Open a page with VE
2.Go to Insert>Formula
3.Attempt to insert "\pi" inside the inspector

Observed Result:
As soon as you type \ in the inspector , it closes and tries to parse that \ and shows error "Failed to parse (lexing error)"


Environment:Betalabs
Browser:Chrome
Comment 1 Bartosz Dziewoński 2014-09-22 21:15:49 UTC
It only closes when you're inserting a new formula. Editing existing ones doesn't have this problem.
Comment 2 James Forrester 2014-09-22 21:21:00 UTC
Focus issue?
Comment 3 Bartosz Dziewoński 2014-09-22 22:24:55 UTC
After dm.Surface emits 'contextChange', ve.ui.Context#afterContextChange thinks that the inspector should be closed, because `selectedNode !== this.lastSelectedNode` (this.lastSelectedNode is null). I spent way too much time debugging this and I still don't know why that happens. It worries me somewhat that `selectedNode` is a paragraph node rather than mwMath node.
Comment 4 Bartosz Dziewoński 2014-09-22 23:05:35 UTC
(The cause is probably 49a239b4b68719dc59bacf79e5186aceca881c58.)
Comment 5 Gerrit Notification Bot 2014-09-23 21:30:22 UTC
Change 162473 had a related patch set uploaded by Bartosz Dziewoński:
ve.ui.Context: Prevent context changes during opening/closing inspectors better

https://gerrit.wikimedia.org/r/162473
Comment 6 Gerrit Notification Bot 2014-09-23 22:52:43 UTC
Change 162495 had a related patch set uploaded by Esanders:
Calculate selected node on change and emit contextChange

https://gerrit.wikimedia.org/r/162495
Comment 7 Gerrit Notification Bot 2014-09-23 23:00:09 UTC
Change 162473 abandoned by Bartosz Dziewoński:
ve.ui.Context: Prevent context changes during opening/closing inspectors better

Reason:
Ed probably knows better.

https://gerrit.wikimedia.org/r/162473
Comment 8 Gerrit Notification Bot 2014-09-24 01:17:30 UTC
Change 162495 merged by jenkins-bot:
Calculate selected node on change and emit contextChange

https://gerrit.wikimedia.org/r/162495
Comment 9 Rummana Yasmeen 2014-09-24 20:40:30 UTC
Verified the fix in Betalabs
Comment 10 Rummana Yasmeen 2014-09-25 22:30:45 UTC
Verified the fix in test2
Comment 11 Rummana Yasmeen 2014-10-02 20:57:41 UTC
Verified the fix in production
Comment 12 Rummana Yasmeen 2014-10-16 01:19:00 UTC
This started happening within last couple of hours
Comment 13 Rummana Yasmeen 2014-10-16 01:20:39 UTC
But the difference is, this time it does not try to parse each time a character is inserted , just closes the inspector
Comment 14 Rummana Yasmeen 2014-10-16 17:38:54 UTC
*** Bug 72136 has been marked as a duplicate of this bug. ***
Comment 15 James Forrester 2014-10-16 17:42:28 UTC
Moving back to "FIXED" and re-using bug 72136.
Comment 16 Rummana Yasmeen 2014-10-20 18:37:01 UTC
Verified the fix in test2 and Betalabs

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links