Last modified: 2014-09-17 01:08:43 UTC
Since build 215 Flow "Lock and unlock topics" browser test has failed on Firefox with "Element is not currently visible and so may not be interacted with" If you watch the screencast, the Lock topic action is indeed off-screen, below the bottom of the window. As we add more items to the action menus, this is more likely to happen. We could position the [...] higher before clicking it, or tell the test to find the action item element, scroll it into view, and then click it. I think a Flow test already solved a similar problem. See e.g. https://integration.wikimedia.org/ci/job/browsertests-Flow-en.wikipedia.beta.wmflabs.org-linux-firefox-sauce/215/testReport/junit/%28root%29/Lock%20and%20unlock%20topics/Locking_a_topic_and_then_changing_your_mind/
Chrome scrolls the menu item into view, Firefox doesn't. See http://stackoverflow.com/a/3403683/451712
Created attachment 16490 [details] console errors in chrome
I'm not seeing Chrome scrolling here, but I get consistent failures at Failing Scenarios: cucumber features/lock_unlock_topics.feature:19 # Scenario: Locking a topic cucumber features/lock_unlock_topics.feature:32 # Scenario: Opening a topic and console errors, see screen shot
You're detecting later bugs :) * The console error & pink errorbox is your bug 70906. * H106: Locked topics should not appear collapsed has a fix pending in Gerrit change #160843. Regardless, if you shrink the window about 30% smaller while the browser test is running, you can see in the "I click the Lock topic button" step where Chrome scrolls that element into view, but Firefox doesn't. I built a simpler test test which assumes the first topic on Talk:Flow_QA is an unmoderated topic: Feature: Test lock menu item Background: Given I am logged in Scenario: Lock menu item Given I am on Flow page When I click the Topic Actions link And I click the Lock topic button And I type "This is a bikeshed" as the reason Then OOPS Run this, again, reduce the height of the window while it's logging in, and Firefox will die while Chrome scrolls the window so 'Lock topic' is visible.