Last modified: 2007-06-27 17:59:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9071, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 7071 - Pages can be edited with an oldid from another page
Pages can be edited with an oldid from another page
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
All All
: Normal minor with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2006-08-20 01:30 UTC by Michael Billington
Modified: 2007-06-27 17:59 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Possible fix (603 bytes, patch)
2006-08-20 06:30 UTC, Wil Mahan

Description Michael Billington 2006-08-20 01:30:11 UTC
When a person reverts a page (without having admin rollback), they are editing
an older version of the page. If you change the oldid in the address bar of your
browser, you can effectively copy the contents of another page onto the page you
are editing. (I'm not sure if this is good or bad) This, when combined with a
bug in a vandal-fighting programme, caused a pretty odd revision to the main page:
It can easily be replicated in my sandbox, see below link:

My thinking is that it should only allow you to edit a page with an oldid from
the same page, or maybe it should give you a different banner at the top of the
page instead of the usual "You are editing a prior version of this page. If you
save it, any changes made since this version will be removed." Any thoughts?
Comment 1 Wil Mahan 2006-08-20 06:30:50 UTC
Created attachment 2255 [details]
Possible fix

Here is a fix, assuming that the new check doesn't
break any valid cases.

It raises another issue though: if a completely
bogus oldid is entered when editing a page, the
error message is displayed inside the edit form.
The page can still be saved, replacing the
article text with the error message. So the fix
probably wouldn't do anything to stop a bot gone
Comment 2 Andrew Garrett 2006-11-13 07:31:32 UTC
The fix is bad. It still allows them to be edited, except instead of giving an
error message, it puts the error message IN the textbox. This is unacceptable.
Comment 3 Brion Vibber 2007-06-27 17:59:41 UTC
Fixed this in r23483 (cf related issue bug 10377).

Note You need to log in before you can comment on or make changes to this bug.