Last modified: 2006-09-11 12:23:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T9064, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 7064 - Replace hard-coded empty message checks with wfEmptyMsg
Replace hard-coded empty message checks with wfEmptyMsg
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.8.x
All All
: Normal trivial with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2006-08-18 22:32 UTC by Dan Li
Modified: 2006-09-11 12:23 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
patch for r16128 to have SkinTemplate use wfEmptyMsg (845 bytes, patch)
2006-08-18 22:33 UTC, Dan Li 		Details
patch (3.85 KB, patch)
2006-09-10 17:38 UTC, Dan Li 		Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Dan Li 2006-08-18 22:32:20 UTC 
SkinTemplate checks for empty messages using <[msg]> instead of wfEmptyMsg.

Not a big deal, but who knows, wfMsg might start returning some other default
message in the future.
Comment 1 Dan Li 2006-08-18 22:33:21 UTC 
Created attachment 2248 [details]
patch for r16128 to have SkinTemplate use wfEmptyMsg
Comment 2 Rob Church 2006-08-18 22:34:05 UTC 
A lot of code does this; SkinTemplate.php is not unique in this respect.
Comment 3 Dan Li 2006-08-18 22:36:58 UTC 
I just happened to see that, looking over SkinTemplate.php. Is there any attempt
to correct this kind of hard-coding in other places?
Comment 4 Dan Li 2006-09-10 17:38:08 UTC 
Created attachment 2339 [details]
patch

I think I found them all...
Comment 5 Brion Vibber 2006-09-11 12:23:33 UTC 
Committed on trunk in r16475
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links