Last modified: 2014-10-02 06:57:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T72134, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 70134 - Deletion page has mw-ui-constructive button, Other/additional reason input is tiny


Summary:	Deletion page has mw-ui-constructive button, Other/additional reason input is...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	MediaWiki UI (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	70135 (view as bug list)
Depends on:
Blocks:	70913
	Show dependency tree / graph

Reported:	2014-08-28 19:08 UTC by Jon
Modified:	2014-10-02 06:57 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
before (52.73 KB, image/png) 2014-09-04 05:13 UTC, Prateek Saxena	Details
after (53.08 KB, image/png) 2014-09-04 05:14 UTC, Prateek Saxena	Details
v2 (25.19 KB, image/png) 2014-09-04 06:11 UTC, Jared Zimmerman (WMF)	Details
Deletion page with wgUseMediaWikiUIEverywhere true (68.21 KB, image/png) 2014-09-09 23:36 UTC, Matthew Flaschen	Details
Add an attachment (proposed patch, testcase, etc.)

Description Jon 2014-08-28 19:08:32 UTC

Delete button on the page http://localhost:8080/wiki/Headings?action=delete is green.

Expected:
It should be red.

Also the input field is tiny. It should be larger.

Comment 1 Derk-Jan Hartman 2014-09-01 13:29:03 UTC

http://en.m.wikipedia.beta.wmflabs.org/wiki/0.8074672945013748?action=delete

Comment 2 Jared Zimmerman (WMF) 2014-09-02 00:48:23 UTC

Only admins can see this page, can you add a screenshot?

But yes probably primary destructive If that's the main action on the page.

Comment 3 Prateek Saxena 2014-09-04 05:13:52 UTC

Created attachment 16361 [details]
before

Comment 4 Prateek Saxena 2014-09-04 05:14:20 UTC

Created attachment 16362 [details]
after

Comment 5 Prateek Saxena 2014-09-04 05:21:20 UTC

Should the delete button be aligned to the right too?

Comment 6 Jared Zimmerman (WMF) 2014-09-04 06:11:30 UTC

Created attachment 16363 [details]
v2

Comment 7 Jared Zimmerman (WMF) 2014-09-04 06:12:27 UTC

we can break it into separate bugs if we like, but might want to update all the controls (that already exist) at the same time.

Comment 8 Jon 2014-09-04 07:53:05 UTC

*** Bug 70135 has been marked as a duplicate of this bug. ***

Comment 9 Prateek Saxena 2014-09-04 11:08:19 UTC

Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page

https://gerrit.wikimedia.org/r/154121

Comment 10 Matthew Flaschen 2014-09-06 01:21:56 UTC

(In reply to Jared Zimmerman (WMF) from comment #7)
> we can break it into separate bugs if we like, but might want to update all
> the controls (that already exist) at the same time.

Actually, it does use the controls that are already implemented.  The reason it looks inconsistent in that screenshot is that it's using the MW UI button even when wgUseMediaWikiUIEverywhere is false (that screenshot was taken with it false).

When that's fixed, we can do a new screenshot with wgUseMediaWikiUIEverywhere set to true.

Comment 11 Matthew Flaschen 2014-09-09 23:36:11 UTC

Created attachment 16423 [details]
Deletion page with wgUseMediaWikiUIEverywhere true

I've attached a screenshot (with the global on) of the latest version.

In my opinion, it's still too short.

Comment 12 Jon 2014-09-09 23:49:40 UTC

Can we merge the existing patch and then raise a new bug to discuss the correct input size? Surely the use of the destructive button is a useful bit of progress? :)

Comment 13 Matthew Flaschen 2014-09-10 00:08:49 UTC

I didn't -1 it, and I don't know if I can review it today regardless, but please at least tag it with the bug.

Comment 14 Gerrit Notification Bot 2014-09-10 00:13:12 UTC

Change 154121 had a related patch set uploaded by Jdlrobson:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled

https://gerrit.wikimedia.org/r/154121

Comment 15 Gerrit Notification Bot 2014-10-02 06:00:53 UTC

Change 154121 merged by jenkins-bot:
Fix styling of deletion page when $wgUseMediaWikiUIEverywhere enabled

https://gerrit.wikimedia.org/r/154121

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links