Last modified: 2014-09-17 06:26:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71886, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69886 - VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc
VisualEditor: Populate LinkCache from MWLinkTargetInputWidget etc
Status: RESOLVED FIXED
Product: VisualEditor
Classification: Unclassified
MediaWiki integration (Other open bugs)
unspecified
All All
: High enhancement
: VE-deploy-2014-09-18
Assigned To: Alex Monk
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-22 06:24 UTC by Roan Kattouw
Modified: 2014-09-17 06:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Roan Kattouw 2014-08-22 06:24:09 UTC 
In MWLinkTargetInputWidget and other places, we perform API requests that give us exactly the kind of information (existence, redirect status, etc.) that goes into ve.init.mw.LinkCache, but we don't write it to the link cache. We should do that, so we can save ourselves some API requests.

Right now, when you make a link, we do another API request to check if the link should be blue or red, even if the link target came from a suggestion list and we already know it should be blue.
Comment 1 Gerrit Notification Bot 2014-08-28 21:10:14 UTC 
Change 156955 had a related patch set uploaded by Alex Monk:
In LinkTargetInputWidget, put existence status into LinkCache

https://gerrit.wikimedia.org/r/156955
Comment 2 Gerrit Notification Bot 2014-08-28 22:17:05 UTC 
Change 156955 merged by jenkins-bot:
In LinkTargetInputWidget, put existence status into LinkCache

https://gerrit.wikimedia.org/r/156955
Comment 3 James Forrester 2014-08-28 23:00:25 UTC 
Do we want to do this from MWTitleInputWidget and MWCategoryInputWidget?
Comment 4 James Forrester 2014-09-07 02:05:08 UTC 
(In reply to James Forrester from comment #3)
> Do we want to do this from MWTitleInputWidget and MWCategoryInputWidget?

Re-opening after discussing with Roan.
Comment 5 Gerrit Notification Bot 2014-09-09 22:41:40 UTC 
Change 159418 had a related patch set uploaded by Alex Monk:
Update LinkCache in MWTitleInputWidget

https://gerrit.wikimedia.org/r/159418
Comment 6 Gerrit Notification Bot 2014-09-10 19:09:07 UTC 
Change 159418 merged by jenkins-bot:
Update LinkCache in MWTitleInputWidget

https://gerrit.wikimedia.org/r/159418
Comment 7 James Forrester 2014-09-10 19:12:47 UTC 
Now just waiting for category existence checking, I believe?
Comment 8 Gerrit Notification Bot 2014-09-10 22:17:29 UTC 
Change 159623 had a related patch set uploaded by Alex Monk:
Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten

https://gerrit.wikimedia.org/r/159623
Comment 9 Gerrit Notification Bot 2014-09-17 02:13:25 UTC 
Change 159623 merged by jenkins-bot:
Refactor a bunch of CategoryInputWidget code, tear out dead/broken redirect handling that should be rewritten

https://gerrit.wikimedia.org/r/159623
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links