Last modified: 2009-03-01 13:36:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T8940, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 6940 - wrong day of the week of Ko:
wrong day of the week of Ko:
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.8.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-08-07 12:48 UTC by klutzy
Modified: 2009-03-01 13:36 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Possible solution to this bug (2.16 KB, patch)
2006-09-29 13:20 UTC, Kang Seonghoon aka Tokigun
Details

Description klutzy 2006-08-07 12:48:47 UTC
signature makes strange day of the week at ko:wp.
for example, see this:
http://ko.wikipedia.org/w/index.php?title=%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EC%82%AD%EC%A0%9C_%ED%86%A0%EB%A1%A0/LG%EC%A0%84%EC%9E%90_%EC%8B%B8%EC%9D%B4%EC%96%B8_%ED%9C%B4%EB%8C%80%ED%8F%B0_%EC%98%A4%EB%A5%98&direction=next&oldid=438518
"2006년 8월 5일 (일)" means "05/08/2006 sun", but the correct day is sat. bug
appears in the afternoon of KST, but not in the morning.
Comment 1 Brion Vibber 2006-08-12 04:11:28 UTC
Please confirm whether still present or fixed.
Comment 2 klutzy 2006-08-13 11:00:55 UTC
still present. :$
Comment 3 Shinjiman 2006-08-13 16:19:16 UTC
The day regression should have no problem since r15927,
however, may anyone please check the messages in MessagesKo.php is that assigned as 
a correct value?

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/languages/MessagesKo.php?
r1=15823&r2=15919

the day messages from r15823 is shown as follows:

'sunday'                => '일요일',
'monday'                => '월요일',
'tuesday'               => '화요일',
'wednesday'             => '수요일',
'thursday'              => '목요일',
'friday'                => '금요일',
'saturday'              => '토요일',
'sun'                   => '일', 
'mon'                   => '월', 
'tue'                   => '화', 
'wed'                   => '수', 
'thu'                   => '목', 
'fri'                   => '금', 
'sat'                   => '토',

Comment 4 klutzy 2006-08-14 13:35:31 UTC
yes, messages are correct.
I guess there is a problem between of UTC and KST because bug occurs only at
evening.
Comment 5 Brion Vibber 2006-08-14 19:34:20 UTC
As far as I can see this actually should work correctly for signatures
(since timezone is set by surrounding code), but incorrectly everywhere
else (since timezone is not set, so will default to UTC on our servers).

Can you confirm that the problem is with signatures and nowhere else?
Or that it's with everything *but* signatures?
Comment 6 klutzy 2006-09-29 08:59:02 UTC
too late. sorry :$

problem is only with signatures. i didn't see any day bug else.
Comment 7 Kang Seonghoon aka Tokigun 2006-09-29 13:20:18 UTC
Created attachment 2421 [details]
Possible solution to this bug

I believe this bug is caused by Language::sprintfDate. Parser::pstPass2 calls
Language::timeanddate with timestamp as server-local timezone, but sprintfDate
seems to parse this timestamp as UTC. I solved this replacing date() to
gmdate().

This patch looks working at least in my laptop, though I haven't check it in
other machines. It needs more verification.

-- Kang Seonghoon aka Tokigun
Comment 8 Kang Seonghoon aka Tokigun 2006-09-29 13:29:46 UTC
Oops, I have made mistake in comment #7 above. Actually sprintfDate accepts
timestamp as server-local timezone, but it uses date() instead of gmdate()
resulting doubled timezone, for example UTC+18:00 instead of UTC+09:00.

-- Kang Seonghoon aka Tokigun
Comment 9 Niklas Laxström 2009-02-28 17:48:39 UTC
Does this problem still happen?
Comment 10 klutzy 2009-03-01 13:36:54 UTC
No. It seems to be fixed a few years ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links