Last modified: 2014-11-12 15:07:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71220, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 69220 - FOUC on slow connections
FOUC on slow connections
Status: PATCH_TO_REVIEW
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-07 10:10 UTC by Matthias Mullie
Modified: 2014-11-12 15:07 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Matthias Mullie 2014-08-07 10:10:46 UTC
As reported by Jon on https://gerrit.wikimedia.org/r/#/c/152104/

Confirmed FOUC on:
* anon warning
* new-topic content textarea

Both of those have .flow-form-collapsible, which will be hidden/displayed by JS based on the form's data-flow-initial-state. Before that JS is loaded/executed, those elements will be visible (though the default state for all currently is to hide them)

We probably have to tweak that implementation. I'd suggest to have the show/hide in CSS rather than JS, roughly like this:

    [data-flow-initial-state=hidden] {
        display: none;
    }
    [data-flow-initial-state=collapsed] .flow-form-collapsible {
        display: none
    }

Rest of the collapse logic can probably stay in JS (I guess.. Other implementations are fine - this is just my initial thought)


Please add to this bug if there are other FOUC that need to be addressed.
Comment 1 Danny Horn 2014-08-12 19:27:13 UTC
in backlog: https://trello.com/c/H8SdP5ep
Comment 2 Gerrit Notification Bot 2014-08-27 00:47:17 UTC
Change 156489 had a related patch set uploaded by Jdlrobson:
Avoid flash of unstyled content on new topic form

https://gerrit.wikimedia.org/r/156489
Comment 3 Gerrit Notification Bot 2014-09-30 14:29:58 UTC
Change 156489 merged by jenkins-bot:
Avoid flash of unstyled content on new topic form

https://gerrit.wikimedia.org/r/156489
Comment 4 Andre Klapper 2014-11-12 15:07:46 UTC
All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links