Last modified: 2014-08-20 14:26:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T71022, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 69022 - Hardcoded path to Popups settings icon
Hardcoded path to Popups settings icon
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Popups (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-01 19:45 UTC by Mormegil
Modified: 2014-08-20 14:26 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mormegil 2014-08-01 19:45:56 UTC 
The settings icon introduced in I374805e is hardcoded to reside at '/w/extensions/Popups/resources/gear_gray.svg' which can’t be right, it needs to be configuration-dependent. For instance, the code does not even work on the WMF cluster, where it leads to 404, check on the testwiki: https://test.wikipedia.org/w/extensions/Popups/resources/gear_gray.svg

Moreover, I don’t think using SVG files directly like this is acceptable, as older browsers do not support SVG. Cf. https://www.mediawiki.org/wiki/Manual:Assets
Comment 1 spage 2014-08-06 20:38:42 UTC 
A fix for both the path and SVG fallback is to put class mwe-popups-settings-icon on a span, and then use the background-image-svg( 'resources/gear_gray.svg', 'resources/gear_gray.png' ) LESS mixin.

Add a comment somewhere saying where the icon came from, and a @TODO use WikiFont glyph.
Comment 2 Prateek Saxena 2014-08-18 10:25:39 UTC 
With I3cf15bc4f9c9f1273b896d0e256f5821f15222fb it now correctly uses `wgExtensionAssetsPath`
Comment 3 Gerrit Notification Bot 2014-08-19 16:54:07 UTC 
Change 155067 had a related patch set uploaded by Prtksxna:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067
Comment 4 Gerrit Notification Bot 2014-08-20 14:12:50 UTC 
Change 155067 merged by jenkins-bot:
article: Fix settings icon

https://gerrit.wikimedia.org/r/155067
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links