Last modified: 2014-07-30 21:04:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70831, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68831 - References parsing JS doesn't recognize cluster of ref links if they have space between links.
References parsing JS doesn't recognize cluster of ref links if they have spa...
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
iOS App (Other open bugs)
Alpha
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-30 00:02 UTC by Monte Hurd
Modified: 2014-07-30 21:04 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Monte Hurd 2014-07-30 00:02:40 UTC 
It works fine if the refs looks like this "[1][2][3]"

But it doesn't if they look like this "[1] [2] [3]"
Comment 1 Bernd Sitzmann 2014-07-30 00:13:50 UTC 
One way to fix this is by replacing nextSibling/previousSibling with nextElementSibling/previousElementSibling. 
The drawback is that it also finds some elements a bit farther away.
Comment 2 Brion Vibber 2014-07-30 17:28:51 UTC 
Got a sample page to test with? Probably easyish to fix per Bernd's note
Comment 3 Bernd Sitzmann 2014-07-30 18:15:27 UTC 
I created one on test wiki, but not sure if they really happen in a real world wiki.
https://test.wikipedia.org/wiki/Reference_Test, refs [4]-[7]
Comment 4 Brion Vibber 2014-07-30 21:04:05 UTC 
Done on the iOS refs branch in: https://gerrit.wikimedia.org/r/#/c/148247/ -- see the goLeft/goRight functions
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links