Last modified: 2014-08-30 13:53:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70730, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68730 - Factor interaction logic out of MergeItems API module, for re-use in SpecialMergeItems
Factor interaction logic out of MergeItems API module, for re-use in SpecialM...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikidataRepo (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Wikidata bugs
u=dev c=backend p=5 s=2014-08-26
:
Depends on:
Blocks: 57745 69106
  Show dependency tree / graph
 
Reported: 2014-07-28 12:15 UTC by tobias.gritschacher
Modified: 2014-08-30 13:53 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description tobias.gritschacher 2014-07-28 12:15:45 UTC 
MergeItems is the most complex API module we have and it needs quite some refactoring/splitting up. What and how exactly should be discussed and turn into small actionable items.
Comment 1 Daniel Kinzler 2014-08-01 11:55:55 UTC 
(updated the summary, changing scope slightly)

MergeItems is not that complex compared to EditEntity or even GetEntities. However, before we add more functionality (like automatically creating redirects), we want to factor the interaction logic (aka business logic) out of the API module, so it can be reused by the correspinding special page.
Comment 2 Daniel Kinzler 2014-08-04 14:22:30 UTC 
Relevant patch https://gerrit.wikimedia.org/r/#/c/151145/

Should be sufficient, I made a new ticket for refactoring SpecialMergeItem (bug 69106).
Comment 3 Gerrit Notification Bot 2014-08-29 14:43:25 UTC 
Change 151145 merged by jenkins-bot:
Introducing MergeItemsInteractor

https://gerrit.wikimedia.org/r/151145
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links